[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] common/util/pub/platform/win hxbacktrace.h,1.1,1.2
From:       dcollins () helixcommunity ! org
Date:       2010-12-10 20:31:09
Message-ID: 201012102031.oBAKV9iO006541 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/common/util/pub/platform/win
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv18840/server/common/util/pub/platform/win

Modified Files:
	hxbacktrace.h 
Log Message:
Synopsis
========
Adds an internal command-line flag to enable/disable verbose Win64 backtraces

Branches: HEAD
Reviewer: Chytanya


Description
===========

Win64 backtrace APIs allow us access to a lot of detailed register
information at each frame of the stack.  Currently, we dump this for
each stack frame in CA/HBFs.  Having chased some CAs, this is too much
information in the normal case.

With this diff, dumping the stack pointers becomes be the default
behavior, with the verbose stack dumps available as a runtime option.
By specifying --vbt (--verbose-back-trace) a Win64 build can still
dump the detailed stack information, which looks like it could be
very useful for certain types of issues.  By default, this verbose
information is disabled.

This command-line flag will be for developer/internal-use only.


Files Affected
==============

server/engine/core/_main.cpp
server/common/util/platform/windows/hxbacktrace.cpp
server/common/util/pub/platform/win/hxbacktrace.h
server/common/util/trace.c


Testing Performed
=================

Unit Tests:
- N/A

Integration Tests:
- Ran a 64-bit release build of the proxy in the Win2k8 uptime rig,
  with and without the --vbt flag, verifying the behavior.

Leak Tests:
- N/A

Performance Tests:
- N/A

Platforms Tested: win-x86_64-vc10
Builds Verified: win-x86_64-vc10, linux-rhel5-x86_64


QA Hints
========
- N/A


Index: hxbacktrace.h
===================================================================
RCS file: /cvsroot/server/common/util/pub/platform/win/hxbacktrace.h,v
retrieving revision 1.1
retrieving revision 1.2
diff -u -d -r1.1 -r1.2
--- hxbacktrace.h	11 Oct 2010 16:05:19 -0000	1.1
+++ hxbacktrace.h	10 Dec 2010 20:31:07 -0000	1.2
@@ -42,8 +42,11 @@
 {
 #endif
 
-    char* HXWinBackTrace(void);
-    char* HXWinThreadBackTrace(HANDLE hThread, int nFramesToSkip, int nFramesToCapture);
+    char* HXWinBackTrace(int bVerbose);
+    char* HXWinThreadBackTrace(HANDLE hThread,
+                               int    nFramesToSkip,
+                               int    nFramesToCapture,
+                               int    bVerbose);
 
 #ifdef __cplusplus
 }


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs
[prev in list] [next in list] [prev in thread] [next in thread]