[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] engine/dataflow http.cpp,1.35,1.36
From:       dcollins () helixcommunity ! org
Date:       2010-11-30 21:02:26
Message-ID: 201011302102.oAUL2SZ3026248 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/engine/dataflow
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv25682/server/engine/dataflow

Modified Files:
	http.cpp 
Log Message:
Synopsis
========
Fixes several uptime issues detected in 64-bit builds

Branches: HEAD
Reviewer: JJ


Description
===========

These are not necessarily 64-bit specific, but were detected
while uptime testing 64-bit builds:

rtmpserv.cpp:
~~~~~~~~~~~~~
A missing new_string() call was causing countless weird CAs all over
the place due to memory corruption caused by a double-delete.

rtmplog.cpp:
~~~~~~~~~~~
The uptimes kept dumping detailed RTMP packet debugging even with it
turned off.  Looking at GetDebugLevel() it was apparent that the use of
the IHXNamedLock interface was unnecessary and eliminated it.  More info
in the comments.  The flag no longer gets assigned bogus values, and
the packet debugging is no longer triggered when off.

http.cpp:
~~~~~~~~
Fixed a CA due to using a file object we'd already called Close() on.

rprxyprt.cpp:
~~~~~~~~~~~~
Fixed a CA.  Need to call Close() on the resolver before releasing it
to get it remove it's callbacks.  These callbacks attepted to call back
into the proxy rtsp protocol object which had already beed deleted.

rtspprxy.cpp:
~~~~~~~~~~~~~
Fixed a CA due parsing an empty log stats string.

sbmonpln.cpp:
~~~~~~~~~~~~~
Fixed a solaris SIGBUS caused by treating a 32-bit integer as a void*
pointer by using PTR_INT, a pointer-sized-integer.


Files Affected
==============

server_rn/protocol/flash/rtmpserv/rtmpserv.cpp
server_rn/protocol/flash/utils/rtmplog.cpp
server/engine/dataflow/http.cpp
server/engine/netio/servsockimp.cpp
server-restricted/proxy/rproxy/rprxyprt.cpp
server-restricted/proxy/rproxy/rtspprxy.cpp
server-restricted/proxy/sbmonpln/sbmonpln.cpp


Testing Performed
=================

Unit Tests:
- N/A

Integration Tests:
- Ran debug uptimes with these fixes on Solaris server+proxy and RHEL5 server.

Leak Tests:
- The RHEL5/x86_64 build shows a significant memory leak, this is being debugged.

Performance Tests:
- N/A

Platforms Tested: linux-rhel5-x86_64, sunos-5.10-sparc-server64
Builds Verified: linux-rhel5-x86_64, sunos-5.10-sparc-server64


QA Hints
========
- N/A


Index: http.cpp
===================================================================
RCS file: /cvsroot/server/engine/dataflow/http.cpp,v
retrieving revision 1.35
retrieving revision 1.36
diff -u -d -r1.35 -r1.36
--- http.cpp	21 Oct 2010 21:33:44 -0000	1.35
+++ http.cpp	30 Nov 2010 21:02:22 -0000	1.36
@@ -1138,6 +1138,7 @@
     if(m_pFileObject)
     {
         m_pFileObject->Close();
+        m_pFileObject = NULL;
         HX_RELEASE(m_pPostHandler);
     }
     else


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs
[prev in list] [next in list] [prev in thread] [next in thread]