[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] common/analysis resolve.pl,1.15,1.16
From:       dcollins () helixcommunity ! org
Date:       2010-10-28 0:58:29
Message-ID: 201010280058.o9S0wd9S016613 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/common/analysis
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv3526

Modified Files:
	resolve.pl 
Log Message:
Synopsis
========
Fixes a resolve.pl parsing glitch with Solaris symbol files

Branches: HEAD
Suggested Reviewers: Anyone (pending)


Description
===========

The recent changes to allow 64-bit pointers caused Solaris resolves to
break due to hex addresses getting an extra unnecessary 0x prefix when
allocating a BigInt.  This fix only adds it if it's not already present
in the address.


Files Affected
==============

server/common/analysis/resolve.pl


Testing Performed
=================

Unit Tests:
- N/A

Integration Tests:
- Resolved a sunos-5.10-sparc32 log with this.

Leak Tests:
- N/A

Performance Tests:
- N/A

Platforms Tested: sunos-5.10-sparc32
Builds Verified: n/a


QA Hints
========
- N/A


Index: resolve.pl
===================================================================
RCS file: /cvsroot/server/common/analysis/resolve.pl,v
retrieving revision 1.15
retrieving revision 1.16
diff -u -d -r1.15 -r1.16
--- resolve.pl	11 Oct 2010 16:08:40 -0000	1.15
+++ resolve.pl	28 Oct 2010 00:58:25 -0000	1.16
@@ -87,7 +87,14 @@
         return (undef, undef) unless $fields[0] =~ /^(0x)?[a-fA-F0-9:]+$/;
         #$fields[0] =~ s/://g;
         $fields[0] =~ s/^[^:]*://g;
-        $address = Math::BigInt->new("0x" . $fields[0]);
+        if ($fields[0] =~ /^0x/i)
+        {
+            $address = Math::BigInt->new($fields[0]);
+        }
+        else
+        {
+            $address = Math::BigInt->new("0x" . $fields[0]);
+        }
         $function = join(" ", @fields[1..$#fields]);
         # AIX debug builds appear to have a ton of these:
         return (undef, undef) if $function =~ /t \.[a-z][a-z]$/;


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs
[prev in list] [next in list] [prev in thread] [next in thread]