[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] admin/web/build/server config_ports.html, 1.7.2.5,
From:       svaidhya () helixcommunity ! org
Date:       2010-03-25 20:15:30
Message-ID: 201003252015.o2PKFQ66019242 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/admin/web/build/server
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv12887

Modified Files:
      Tag: SERVER_14_0
	config_ports.html 
Log Message:
Synopsis
========
Unable to change Enable Control Port Security in the Admin


Branch : SERVER_14_0_RN, HEAD
Suggested Reviewer: Dean

Description
==========

The function which checks port conflicts searches for substring 'port' 
in the list of ports displayed on the page and compares its value with all other port \
values for any conflicts.

Since the EnableControlPortSecurity' has 'port' in it, it considers it as a port \
variable and messes up things ahead.

Ideally the fix would be to store the list of ports somewhere and then consider only \
those for comparison but for now, to minimize any errors, I am not proceeding with \
that iteration if the parameter changed is EnableControlPortSecurity.



Files Changed:
============
./server/admin/web/src.srvrprxy/conpif_ports.html.wasm
mproxy, proxy, mserver, server targets affected.


Testing Performed
=================
Unit Tests:
- None

Integration Tests:
- Verified EnableControlPortSecurity and other ports can be modified from admin page.

 
Leak Tests: 
- None.

Performance Tests:
- None

Build verified: win32-i386-vc7
Platform tested : win32-i386-vc7	



Index: config_ports.html
===================================================================
RCS file: /cvsroot/server/admin/web/build/server/config_ports.html,v
retrieving revision 1.7.2.5
retrieving revision 1.7.2.6
diff -u -d -r1.7.2.5 -r1.7.2.6
--- config_ports.html	18 Mar 2010 23:34:04 -0000	1.7.2.5
+++ config_ports.html	25 Mar 2010 20:15:27 -0000	1.7.2.6
@@ -91,7 +91,9 @@
 	for ( var propName in propList.props() )
 	{
 		var prop = propList.prop( propName );
-		if ( prop && prop.isDirty() && propName.bSearch( /port/i ) )
+                //We need to have a list of ports and the whole page should be \
modified to use that list. +                //For now just not proceeding if propname \
is EnableControlPortSecurity +		if ( prop && prop.isDirty() && (propName != \
"EnableControlPortSecurity") && propName.bSearch( /port/i ) )  {
 			ctrl = (propName.bSearch( /Range/ ) ? theForm.PortRange0 : 
 					prop.getCtrl( theForm )); //TODO create a PortRange sub class of PropObj!


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs


[prev in list] [next in list] [prev in thread] [next in thread]