[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] protocol/rtsp rtspmsg2.cpp,1.19,1.20
From:       jzeng () helixcommunity ! org
Date:       2010-02-28 16:43:37
Message-ID: 201002281643.o1SGhdxp028004 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/protocol/rtsp
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv22633/server/protocol/rtsp

Modified Files:
	rtspmsg2.cpp 
Log Message:
Synopsis 
============ 
Bug 255454:   RNKK: Options.ClientRequestTotal value and
Describe.ClientRequestTotal value on Helix Mobile Proxy 13 do not show
the right value.

Branches:  head, SERVER_14_RN 
Suggested Reviewer: anyone

Description 
=========== 
The problem is due to some messages are counted twice.  For example, the options request from the
client is counted the first time in OnMessage, then saved.  The next time after the connection to
the server is established, OnMessage is called again and the same message is counted again.

I spent a lot time trying to fix it on the proxy code, but finally gave up because the code is too
complex for me to modify at this stage.

Instead I added a member to rtmpmessage to indicate whether they had been counted.  This is a safe
fix as it doesn't change anything in the proxy.

Files Affected 
============== 
server/protocol/rtsp/rtspmsg2.cpp,v
server/protocol/rtsp/pub/rtspmsg2.h,v
proxy-restricted/proxy/rproxy/rtspprxy.cpp,v


Testing Performed 
================= 

Unit Tests: 
None. 

Integration Tests: 
Verify the counters are correct.

Leak Tests: 
None. 

Performance Tests: 
- None 

Platforms Tested: linux-rhel4-i686 
Build verified: linux-rhel4-i686 





Index: rtspmsg2.cpp
===================================================================
RCS file: /cvsroot/server/protocol/rtsp/rtspmsg2.cpp,v
retrieving revision 1.19
retrieving revision 1.20
diff -u -d -r1.19 -r1.20
--- rtspmsg2.cpp	10 Apr 2008 17:19:56 -0000	1.19
+++ rtspmsg2.cpp	28 Feb 2010 16:43:35 -0000	1.20
@@ -303,6 +303,7 @@
     , m_bFullyQualifiedURL(FALSE)
     , m_bProxyGeneratedRequest(FALSE)
     , m_bIsProxy(FALSE)
+    , m_bEventCounted(FALSE)
 {
     if (m_pFastAlloc)
     {


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs
[prev in list] [next in list] [prev in thread] [next in thread]