[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] engine/core/pub proc_container.h,1.32,1.33
From:       dcollins () helixcommunity ! org
Date:       2009-11-30 19:02:26
Message-ID: 200911302015.nAUKF16h011703 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/engine/core/pub
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv24654/server/engine/core/pub

Modified Files:
	proc_container.h 
Log Message:
Synopsis
========
Fixes PR 254273: Admin UI does not save any changes made through it and
    gives a 404 on attempting the change

Branches: SERVER_CURRENT_RN (HEAD)
Reviewer: Jamie


Description
===========

When I originally implemented and tested HTTPS support for the admin
system, I was reusing the AdminPort variable for HTTPS.  Later we decided
to allow both HTTP or HTTPS, and to configure each seperately, using
SecureAdminPort for HTTPS.  This resulted in a couple of admin system
failures.

This fixes two problems, one where we were not checking the HTTPSPostable
list for HTTPS connections, and the other where some admin system
javascript was not inserting the correct port into admin URLs.
These resulted in HTTP errors and failure to update config variables.


Files Affected
==============

server/engine/core/core_proc.cpp
server/engine/core/proc_container.cpp
server/engine/core/pub/proc_container.h
server/engine/dataflow/http.cpp
server/admin/web/src/srvprxy/config_results.nc.html.wasm
server/admin/web/build/mproxy/config_results.nc.html
server/admin/web/build/mserver/config_results.nc.html
server/admin/web/build/proxy/config_results.nc.html
server/admin/web/build/server/config_results.nc.html


Testing Performed
=================

Unit Tests:
- N/A

Integration Tests:
- Configured admin variables via both HTTPS and HTTP.

Leak Tests:
- N/A

Performance Tests:
- N/A

Platforms Tested: win32-i386-vc7
Build verified: win32-i386-vc7


QA Hints
========
* N/A


Index: proc_container.h
===================================================================
RCS file: /cvsroot/server/engine/core/pub/proc_container.h,v
retrieving revision 1.32
retrieving revision 1.33
diff -u -d -r1.32 -r1.33
--- proc_container.h	17 Nov 2009 02:12:57 -0000	1.32
+++ proc_container.h	30 Nov 2009 19:02:24 -0000	1.33
@@ -201,6 +201,7 @@
     char***                     HTTP_deliver_paths;
     char***                     HTTPS_deliver_paths;
     char***                     HTTP_postable_paths;
+    char***                     HTTPS_postable_paths;
     char*                       m3ugen_moutpoint;
     CHXThreadSafeMap*           cloaked_guid_dict;
     CHXThreadSafeMap*           fcs_session_map;


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs
[prev in list] [next in list] [prev in thread] [next in thread]