[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] broadcast/transport/rtp/recv rtpstream.cpp,1.2,1.3
From:       ckarusala () helixcommunity ! org
Date:       2009-06-19 1:33:19
Message-ID: 200906190238.n5J2cvQs012301 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/broadcast/transport/rtp/recv
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv1056

Modified Files:
	rtpstream.cpp 
Log Message:
Synopsis
========
This CR fixes PR 244169: Broadcasts from v12 to v13 of RTP live A/V containing AAC \
audio not playable


Branch : SERVER_13_0_RN, HEAD
Suggested Reviewer : Jamie


Description:
==========
Wiredpayload stream headers do not contain BaseRule information. In \
RTPStream::Init(), if BasRule is not found, m_unBaseRule is getting initialized to \
incorrect value (stream number in this case). So for audio stream this is 1. For AAC \
codecs, all the packets are arriving with market bit set to 1 and hence the \
ASMRuleNumber for audio packets is getting set to 2. PPM & MDP are dropping these \
packets as the rule number 2 is not a valid subscribed rule. Fix is to initialize the \
temporary variable to zero so that m_unBaseRule gets initialized to 0 when there is \
no BaseRule in the headers.


Files Affected
==============
server/broadcast/transport/rtp/recv/rtpstream.cpp


Testing Performed
=================


Unit Tests:
- Tested with SR RTP live from 12.0.1 -> 13 with all the five audio combinations with \
H263 video. Playback was fine. Some times, first client is either getting stuck at \
99% loading or a/v is getting out of sync. Jamie and I are investigating this issue \
in parallel.


Integration Tests:
- None


Leak Tests:
- None.


Performance Tests:
- None


Build verified: win32-i386-vc7
Platform tested : win32-i386-vc7


Thanks,
Chytanya



Index: rtpstream.cpp
===================================================================
RCS file: /cvsroot/server/broadcast/transport/rtp/recv/rtpstream.cpp,v
retrieving revision 1.2
retrieving revision 1.3
diff -u -d -r1.2 -r1.3
--- rtpstream.cpp	7 Apr 2009 20:07:33 -0000	1.2
+++ rtpstream.cpp	19 Jun 2009 01:33:17 -0000	1.3
@@ -165,6 +165,7 @@
     m_pStreamHeader->GetPropertyULONG32("StreamNumber", ulTmp);
     m_unInStream = (UINT16)ulTmp;
 
+    ulTmp = 0;
     m_pStreamHeader->GetPropertyULONG32("BaseRule", ulTmp);
     m_unBaseRule = (UINT16)ulTmp;
 


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs


[prev in list] [next in list] [prev in thread] [next in thread]