[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] engine/session clientsession.cpp, 1.72.2.41.2.45.2.18,
From:       dcollins () helixcommunity ! org
Date:       2009-06-18 23:55:45
Message-ID: 200906190101.n5J11Omx007531 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/engine/session
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv28440/server/engine/session


Modified Files:
      Tag: SERVER_13_0
	clientsession.cpp 
Log Message:
Synopsis
========
Allow setting UseServerSideRateAdaptationForLive to "always"

Branches: SERVER_13_0, HEAD
Reviewer: Chytanya


Description
===========

Due to handset limitations, the code we added to treat "always"
like "clientselect" for live was not going to work, so I was
asked to allow setting UseServerSideRateAdaptationForLive to "always".
In clientsession.cpp, we revert the forcing of "clientselect".
In config_mduap.html.wasm and the corresponding html pages,
we allow selecting "Always" when configuring this value.
And finally, in the NokiaR1M.uas file, we change this
value to "always" for the Nokia N78, N85 & N96 handsets.

Files Affected
==============

server/engine/session/clientsession.cpp
server/admin/web/src/srvprxy/config_mduap.html.wasm
server/admin/web/build/mproxy/config_mduap.html
server/admin/web/build/mserver/config_mduap.html
server/admin/web/build/proxy/config_mduap.html
server/admin/web/build/server/config_mduap.html
server-restricted/installer/files/NokiaR1M.uas


Testing Performed
=================

Unit Tests:
- N/A.

Integration Tests:
- Used the admin system to configure a UAS to have the "always" setting.

Leak Tests:
- N/A.

Performance Tests:
- N/A.

Platforms Tested: linux-rhel4-i686
Build verified: linux-rhel4-i686


QA Hints
========
* Verify config setting works via the admin system.
* Verify playback uses MDP for live when this is configured.



Index: clientsession.cpp
===================================================================
RCS file: /cvsroot/server/engine/session/clientsession.cpp,v
retrieving revision 1.72.2.41.2.45.2.18
retrieving revision 1.72.2.41.2.45.2.19
diff -u -d -r1.72.2.41.2.45.2.18 -r1.72.2.41.2.45.2.19
--- clientsession.cpp	8 Jun 2009 20:41:19 -0000	1.72.2.41.2.45.2.18
+++ clientsession.cpp	18 Jun 2009 23:55:43 -0000	1.72.2.41.2.45.2.19
@@ -1998,16 +1998,8 @@
 
                 if (!strcasecmp("always", (const char*)pBuffer->GetBuffer()))
                 {
-                    //For PhaseI of LRA, if "always", it should be interpreted as \
                "clientselect" for live
-                    if (bIsLive)
-                    {
-                       m_UseMediaDeliveryPipeline = CLIENTSELECT;
-                    }
-                    else
-                    {
-                        m_UseMediaDeliveryPipeline = ALWAYS;
-                        m_bUseMDP = TRUE;
-                    }
+                    m_UseMediaDeliveryPipeline = ALWAYS;
+                    m_bUseMDP = TRUE;
                 }
                 else if (!strcasecmp("never", (const char*)pBuffer->GetBuffer()))
                 {


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs


[prev in list] [next in list] [prev in thread] [next in thread]