[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] admin/web/src/js ip.js.wasm,1.2.48.1,1.2.48.2
From:       svaidhya () helixcommunity ! org
Date:       2009-05-30 20:51:13
Message-ID: 20090530215558.C552C30AD23 () pukcab ! korelogic ! com
[Download RAW message or body]

Update of /cvsroot/server/admin/web/src/js
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv31072

Modified Files:
      Tag: SERVER_13_0
	ip.js.wasm 
Log Message:
Implemented Review Comments

Synopsis
========
Admin system needs to universally accept (and add) brackets around IPv6 addresses


Branches:  SERVER_CURRENT, SERVER_13_0
Reviewer(s): Dean, Chytanya


Description
===========

The server requires the IPv6 address to be enclosed within square brackets. But the \
admin system does not allow [] in any address.

There are 2 things to be taken care of:

1. If the IP Address is enclosed within [], the admin system should recognize it as a \
valid IP Address

   Made changes to a couple of places (common code used by all pages containing an IP \
Address input  field) to recognize [] as a valid IP v6 address.

2. If the an IPv6 address is not enclosed inside Sq bracket the admin system puts it \
within [] and  write to config file.

   Implementing this would take sometime. So for now if the user enters a valid IPv6 \
adress w/o  square bracktes, the admin sys would prompt the user to enclose IP \
Address within [].


Files Affected
==============
./server/admin/web/src/js/ip.js.wasm
./server/admin/web/src/js/client.js.wasm

HTML Files

./server/admin/web/build/(*)/ip.js
./server/admin/web/build/(*)/client.js


Testing Performed
=================
Unit Tests:
None.

Integration Tests:
- Verified the following

  - When an IPv6 Address WITH [] is entered, admin system accepts it and writes the \
address with []  in the config file.
  - When an IPv6 Address WITHOUT [] is entered, admin system  prompts the user to \
                enter it with []
  - When an IPv6 Address WITH MULTIPLE [] is entered, admin system complains about \
the IP being  invalid
  - When an IPv4 Address WITH [] is entered, admin system complains about the IP \
being  invalid
  - When an IPv4 Address WITHOUT [] is entered, admin system accepts it and writes \
the address  in the config file.

Leak Tests:
- None.

Performance Tests:
None.

Platforms Tested:  win32-i386-vc7
Build verified:    win32-i386-vc7 


Index: ip.js.wasm
===================================================================
RCS file: /cvsroot/server/admin/web/src/js/ip.js.wasm,v
retrieving revision 1.2.48.1
retrieving revision 1.2.48.2
diff -u -d -r1.2.48.1 -r1.2.48.2
--- ip.js.wasm	30 May 2009 20:40:58 -0000	1.2.48.1
+++ ip.js.wasm	30 May 2009 20:51:11 -0000	1.2.48.2
@@ -73,7 +73,7 @@
 	    if (this.isIPv4 && this.hasBracket)
 	    {
 		this.isValid = false;
-		this.errMsg = "Invalid IP Address";
+		this.errMsg = "Please remove brackets around the IP Address";
 	    }
 	}
     


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs


[prev in list] [next in list] [prev in thread] [next in thread]