[prev in list] [next in list] [prev in thread] [next in thread]
List: helix-server-cvs
Subject: [Server-cvs] admin/web/src/js client.js.wasm,1.3,1.4
From: svaidhya () helixcommunity ! org
Date: 2009-05-30 20:43:44
Message-ID: 20090530214820.A9DE630ACD5 () pukcab ! korelogic ! com
[Download RAW message or body]
Update of /cvsroot/server/admin/web/src/js
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv30870
Modified Files:
client.js.wasm
Log Message:
Synopsis
========
Admin system needs to universally accept (and add) brackets around IPv6 addresses
Branches: SERVER_CURRENT, SERVER_13_0
Reviewer(s): Dean
Description
===========
The server requires the IPv6 address to be enclosed within square brackets. But the \
admin system does not allow [] in any address.
There are 2 things to be taken care of:
1. If the IP Address is enclosed within [], the admin system should recognize it as a \
valid IP Address
Made changes to a couple of places (common code used by all pages containing an IP \
Address input field) to recognize [] as a valid IP v6 address.
2. If the an IPv6 address is not enclosed inside Sq bracket the admin system puts it \
within [] and write to config file.
Implementing this would take sometime. So for now if the user enters a valid IPv6 \
adress w/o square bracktes, the admin sys would prompt the user to enclose IP \
Address within [].
Files Affected
==============
./server/admin/web/src/js/ip.js.wasm
./server/admin/web/src/js/client.js.wasm
HTML Files
./server/admin/web/build/(*)/ip.js
./server/admin/web/build/(*)/client.js
Testing Performed
=================
Unit Tests:
None.
Integration Tests:
- Verified the following
- When an IPv6 Address WITH [] is entered, admin system accepts it and writes the \
address with [] in the config file.
- When an IPv6 Address WITHOUT [] is entered, admin system prompts the user to \
enter it with []
- When an IPv6 Address WITH MULTIPLE [] is entered, admin system complains about \
the IP being invalid
- When an IPv4 Address WITH [] is entered, admin system complains about the IP \
being invalid
- When an IPv4 Address WITHOUT [] is entered, admin system accepts it and writes \
the address in the config file.
Leak Tests:
- None.
Performance Tests:
None.
Platforms Tested: win32-i386-vc7
Build verified: win32-i386-vc7
Index: client.js.wasm
===================================================================
RCS file: /cvsroot/server/admin/web/src/js/client.js.wasm,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -d -r1.3 -r1.4
--- client.js.wasm 20 Nov 2007 12:36:11 -0000 1.3
+++ client.js.wasm 30 May 2009 20:43:42 -0000 1.4
@@ -1151,7 +1151,8 @@
if ( addr.bSearch( /\:/ ) )
{
// just hex digits, colons, dots and '/' ?
- return addr.bSearch( /^ *[\dA-F\.\:\/]+ *$/i );
+ //Also allow v6 address enclosed winthin square brackets
+ return addr.bSearch( /^ *\[?[\dA-F\.\:\/]+\]? *$/i );
}
else
{
_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic