[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] engine/netio servsockimp.cpp,1.58,1.59
From:       dcollins () helixcommunity ! org
Date:       2009-05-30 20:16:51
Message-ID: 20090530212435.7E1E130AC26 () pukcab ! korelogic ! com
[Download RAW message or body]

Update of /cvsroot/server/engine/netio
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv28704

Modified Files:
	servsockimp.cpp 
Log Message:
Synopsis
========
Fixes a socket callback leak on win32

Branches: SERVER_13_0, HEAD
Reviewers: Anyone


Description
===========

A per-connection leak of SocketInfo objects was found while debugging
memory leaks for PR 240901.  This leak is Windows-specific, so it will not
address any memory leaks that might still be present on other platforms.


Files Affected
==============

server/engine/netio/servsockimp.cpp


Testing Performed
=================

Unit Tests:
- N/A.

Integration Tests:
- Leak isolated using a subset of a standard uptime, exercizing RM live MR.

Leak Tests:
- Ran an instrumented server to validate that the new code is
  executed and that the leak of SocketInfo objects no longer occured.
- Ran a leak-check test to validate that the stack no longer appears
  in the leak-check results.

Performance Tests:
- N/A.

Platforms Tested: win32-i386-vc7
Build verified: win32-i386-vc7


QA Hints
========
* Run an updated server and proxy in an uptime and observe memory behavior on all platforms.



Index: servsockimp.cpp
===================================================================
RCS file: /cvsroot/server/engine/netio/servsockimp.cpp,v
retrieving revision 1.58
retrieving revision 1.59
diff -u -d -r1.58 -r1.59
--- servsockimp.cpp	27 Apr 2009 23:20:26 -0000	1.58
+++ servsockimp.cpp	30 May 2009 20:16:48 -0000	1.59
@@ -530,6 +530,9 @@
         {
             m_pProc->pc->engine->callbacks.remove(HX_READERS, m_sock.sock);
             m_pProc->pc->engine->callbacks.remove(HX_WRITERS, m_sock.sock);
+#ifdef _WIN32
+            m_pProc->pc->engine->callbacks.remove(HX_CONNECTORS, m_sock.sock);
+#endif
             m_pProc->pc->engine->UnRegisterSock();
             m_bRemovedCallbacks = TRUE;
         }


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs

[prev in list] [next in list] [prev in thread] [next in thread]