[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] qos/transport qos_tran_cc.cpp, 1.91.8.10.2.1,
From:       atin () helixcommunity ! org
Date:       2009-02-27 21:39:14
Message-ID: 200902272139.n1RLdDVk008143 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/qos/transport
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv23322

Modified Files:
      Tag: SERVER_12_1
	qos_tran_cc.cpp 
Log Message:
Synopsis
========
when testing live/on-demand via mdp using TFRC, the recvd_rate calcultion was
incorrect.

Branches: SERVER_12_1, SERVER_CURRENT
Reviewed by: jgordon


Description
===========
via rtp the recvd-rate was being calculated as bytes-per-sec and with rdt it
was bits-per-sec. also, in the tfrc reporting the recvd_rate was being
multiplied by 8 (assuming that it was bytes-per-sec). there are other
calculations in tfrc that were bits-per-sec. so it seemed like an oversight
error when changes were made by some dev in the past.

the fix was to make the rtp recvd rate be bits-per-sec and remove the "*8"
from the recvd_rate printf().


Files Affected
==============
server-restricted/qos/transport/qos_tran_tfrc_rtcp.cpp
server/qos/transport/qos_tran_cc.cpp


Testing Performed
=================
Unit Tests:
N/A

Integration Tests:
(1) tested with on-demand rm files.
(2) tested with live via slta (rdt) and hmp (rtp).

Leak Tests:
N/A

Performance Tests:
N/A

Platforms Tested: sunos-5.10-sparc-server, linux-rhel4-i686
Build verified: sunos-5.10-sparc-server, linux-rhel4-i686, win32-i386-vc7

QA Hints
========
the recvd_rate value in the tfrc reports should be correct (close to the media
rate).



Index: qos_tran_cc.cpp
===================================================================
RCS file: /cvsroot/server/qos/transport/qos_tran_cc.cpp,v
retrieving revision 1.91.8.10.2.1
retrieving revision 1.91.8.10.2.2
diff -u -d -r1.91.8.10.2.1 -r1.91.8.10.2.2
--- qos_tran_cc.cpp	25 Feb 2009 00:57:02 -0000	1.91.8.10.2.1
+++ qos_tran_cc.cpp	27 Feb 2009 22:23:30 -0000	1.91.8.10.2.2
@@ -1547,19 +1547,18 @@
     if (unPktCnt != 0)
     {
         Timeval tTimeDiff = tvArrivalTime - m_tLastRR;
-        fPPS = (double)((((double)
-                          (m_ulLastRecvd))/
-                         ((double)(tTimeDiff.tv_sec*MILLISECOND) +
-                          (tTimeDiff.tv_usec/MILLISECOND)))*1000);
+        fPPS = (double)((((double)(m_ulLastRecvd)) /
+                         ((double)(tTimeDiff.tv_sec * MILLISECOND) +
+                          (tTimeDiff.tv_usec / MILLISECOND))) * 1000);
 
-        UINT32 ulIntvlSample = ((tTimeDiff.tv_sec*MILLISECOND) +
-                                ((tTimeDiff.tv_usec/MILLISECOND)*1000));
+        UINT32 ulIntvlSample = ((tTimeDiff.tv_sec * MILLISECOND) +
+                                ((tTimeDiff.tv_usec / MILLISECOND) * 1000));
 
         m_fRRIntvl = (m_fRRIntvl) ?
             (double)((1 - AVG_PKT_SZ_FILTER) * m_fRRIntvl +
                      AVG_PKT_SZ_FILTER * ((double)(ulIntvlSample))) : (double)ulIntvlSample;
 
-        m_fRecvdRate = fPPS*(m_ulAvgPacketSize >> AVG_PKT_SZ_FILTER);
+        m_fRecvdRate = fPPS * m_ulAvgPacketSize; // bits-per-sec
 
         SignalRTPWindowedReceiveRate(fPPS);
     }


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs
[prev in list] [next in list] [prev in thread] [next in thread]