[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] broadcast/transport/rtp/recv Umakefil,1.11,1.12
From:       svaidhya () helixcommunity ! org
Date:       2008-12-11 23:57:23
Message-ID: 200812112358.mBBNw06L014938 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/broadcast/transport/rtp/recv
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv10215

Modified Files:
	Umakefil 
Log Message:
Synopsis
========
Implementation of Multirate RTP Live Ingress

Branches:  SERVER_CURRENT, SERVER_12_1
Reviewer(s): chytanya, Jamie

Description
===========
1. Replace the existing SDP Parsing Code in qtbcpln with SDP parser available (Plugin \
- hxsdp.so)  This involved changes in both qtcbpln(qtbcobj.cpp, qtbcobj.h) and SDP \
plugin(sdpmdparse.cpp and sdpmdparse.h) 2. Created new methods creating StreamGroups \
and SwitchGroups, ASMRueBooks and Handling Alt-Ids  The new methods have been added \
as static methods in CHXAltGroupUtil (protocol/common/util) 3. For checking if two \
stream are switch compatible the "switchverifier" \
(/server-restricted/datatype/switch) is used.  In this case the Bitrate checks in \
switchverifer are not performed. (switchverifier.h, switchverifier.cpp) 4. A new \
SERVER_FEATURE variable is #defined "HELIX_FEATURE_SERVER_MR_RTP" for allowing \
multiple bitrates

Chytanya's Review Comments
===========================

1. Use HXR_OK to check if SwitchID Exists in CreateASMRuleBook()
2. Change HX_DELETE to HX_VECTOR_DELETE
3. Move the setting of "ForceRTP" flag from GetStreamHeader() to ParseSDPFile()
4. A couple of Leaks resolved

Files Affected
==========
  qtbcpln Files
   ~~~~~~~~
  /server/broadcast/transport/rtp/recv/qtbcobj.cpp
  /server/broadcast/transport/rtp/recv/qtbcobj.h
  /server/broadcast/transport/rtp/recv/Umakefil
  /server/broadcast/transport/rtp/recv/guids.cpp

  SwitchVerifier Changes (BitRate check disable)
  ~~~~~~~~~~
  /server-restricted/datatype/switch/switchverifier.cpp
  /server-restricted/datatype/switch/pub/switchverifier.h

  SDP Parser Changes (hxsdp Plugin)
  ~~~~~~~~
  /protocol/sdp/sdpmdparse.cpp
  /protocol/sdp/pub/sdpmdparse.h

  Util Methods
  ~~~~~~~~~
  /protocol/common/util/altgrputil.cpp
  /protocol/common/util/Umakefil
  /protocol/common/util/pub/altgrputil.h

Testing Performed
=================
Unit Tests:
None.

Integration Tests:
- Tested for single rate streams and multi rate streams

Leak Tests:
None.

Performance Tests:
None.

Platforms Tested: : win32-i386-vc7
Build verified: linux-rhel4-i686, win32-i386-vc7 



Index: Umakefil
===================================================================
RCS file: /cvsroot/server/broadcast/transport/rtp/recv/Umakefil,v
retrieving revision 1.11
retrieving revision 1.12
diff -u -d -r1.11 -r1.12
--- Umakefil	11 Jan 2007 02:31:33 -0000	1.11
+++ Umakefil	11 Dec 2008 23:57:20 -0000	1.12
@@ -41,13 +41,24 @@
     "common/dbgtool/pub",
     "common/netio/pub",
     "common/runtime/pub",
+    "protocol/sdp/pub",
+    "protocol/common/util/pub",
     "server/include",
     "server/common/util/pub",
+    "datatype/rm/include",
+    "datatype/rm/audio/common/pub",
     "server/datatype/common/pktskim")
 
 project.AddSources("qtbcplin.cpp", "qtbcobj.cpp", "qtstream.cpp", 
     "sdpinfo.cpp", "qtdirmgr.cpp", "guids.cpp", "qtreceiver.cpp", "bitbucket.cpp")
 
+if "HELIX_FEATURE_SERVER_MR_RTP" in project.defines:
+        project.AddModuleIncludes("server-restricted/datatype/switch/pub")
+
+if "HELIX_FEATURE_SERVER_MR_RTP" in project.defines:
+        project.AddModuleLibraries \
("server-restricted/datatype/switch[switchverifierlib]",  +                           \
"datatype-restricted/rm/audio/common[racomlib]") +
 project.AddModuleLibraries(
     "server/common/util[servutillib]",
     "server/datatype/common/pktskim[pktskimlib]",


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs


[prev in list] [next in list] [prev in thread] [next in thread]