[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] protocol/transport/rdt rdt_base.cpp, 1.9.20.2,
From:       jzeng () helixcommunity ! org
Date:       2008-11-07 21:42:06
Message-ID: 200811072149.mA7LnZ7O029421 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/protocol/transport/rdt
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv19548

Modified Files:
      Tag: SERVER_12_0
	rdt_base.cpp 
Log Message:
Synopsis
========
Fix Bug 230947:  Packet loss reported at the end of successful playback
Branches:  head, server_12_1, server12_0 Suggested Reviewer: anyone

Description
===========
This bug is introduced by the transport refactor. The server didn't shrink the streamEnd packet
before sending it out, so the player thought there is a data packet behind it, and everything is
screwed up.

Files Affected
==============

server/protocol/transport/rdt/rdt_base.cpp

Testing Performed
=================

Unit Tests:
None.

Integration Tests:
Verify no packet loss reported on the player.

Leak Tests:
None.

Performance Tests:
- None

Platforms Tested: linux-rhel4-i686
Build verified: linux-rhel4-i686





Index: rdt_base.cpp
===================================================================
RCS file: /cvsroot/server/protocol/transport/rdt/rdt_base.cpp,v
retrieving revision 1.9.20.2
retrieving revision 1.9.20.2.4.1
diff -u -d -r1.9.20.2 -r1.9.20.2.4.1
--- rdt_base.cpp	24 Jan 2008 07:27:44 -0000	1.9.20.2
+++ rdt_base.cpp	7 Nov 2008 21:42:03 -0000	1.9.20.2.4.1
@@ -396,6 +396,11 @@
         pkt.ext_flag = 0;
     }
     pkt.pack(packet, packetLen);
+    if(packetLen < pkt.static_size())
+    {
+        pSendBuffer->SetSize(packetLen);
+    }
+
     // writePacket will call pSendBuffer->Release()
     hresult = writePacket(pSendBuffer);
 


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs
[prev in list] [next in list] [prev in thread] [next in thread]