[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] installer/common/scripts installer.py,1.8,1.8.34.1
From:       dcollins () helixcommunity ! org
Date:       2008-04-25 22:01:05
Message-ID: 200804252201.m3PM1H1I011094 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/installer/common/scripts
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv23802

Modified Files:
      Tag: SERVER_12_1
	installer.py 
Log Message:
Synopsis
========
Updates the DNA/Plus/Restricted server installers based on msvcp71/msvcr71
    DLL-related build farm updates (PR 217251)

Branches: SERVER_12_1_RN, SERVER_CURRENT_RN
Reviewer: Jamie


Description
===========

This is a follow-up 12.1/HEAD check-in to the fix for:
    217251: Windows server/proxy installer fails to copy required system
        dlls(msvcr71, msvcp71) to the Bin directory

While investigating the above issue, I discovered that the build farm
systems were not setting the %FrameworkSDKDir% environment variable,
despite it being a part of the standard Visual Studio 7 build environment.
To get the 12.0 RC a temporary solution was checked in.

Prior to the above fix, the installers were silently failing to include
the Visual C/C++ runtime files in the installer when building on the build
farm, yet they would be included for private developer builds.

I worked with ELabs/PDST to determine the build farm fix, and get it
rolled out to all relevant build farm hosts.  

Now that the build farm is correctly defining this environment variable,
the logic to silently fall back and/or fail is being removed.  It is
better for this to fail, with a clear error message, and the build
environment be fixed.  This will help us avoid future permutations
of PR 217251 ("RC build doesn't even run!").

This change will be bubbled to all server-related installers on all
affected branches.  The change is nearly identical, though the filename
differs slightly:

- Helix Mobile Server Installer
- Helix (Wireline) Server Installer
- Helix Mobile Proxy Installer
- Helix (Wireline) Proxy Installer
- Helix Restricted Mobile Server Installer
- Helix Restricted Mobile Proxy Installer
- Helix DNA Server Plus Installer
- Helix DNA Server Installer
- Helix SLTA Installer

Note, to test this I had to check in the change for one of the 
above installers on the HEAD so that test builds could be fired-off
on the build farm.  

Files Affected
==============

server-restricted/installer/server/make_tempdir
server-restricted/broadcast/app/slta/make_tempdir
server/installer/hlxserver/nodist/copyfiles_win32.py
server/installer/hlxserver/plus/copyfiles_win32.py
server/installer/common/scripts/installer.py


Testing Performed
=================

Unit Tests:
- None

Integration Tests:
- Ran release build of the HEAD DNA server installer compiled on the
     build farm after the build farm fixes.
- Verified above installer placed the DLLs in the Bin directory.

Leak Tests:
- None

Performance Tests:
- None

Platforms Tested: win32-i386-vc7
Build verified: win32-i386-vc7


QA Hints
===============
- To really test this you need to test on a "clean" fresh install of Windows.
- Note: Check all server, proxy and slta installers, not just the server.
  This includes all DNA, Plus and Restricted installers.



Index: installer.py
===================================================================
RCS file: /cvsroot/server/installer/common/scripts/installer.py,v
retrieving revision 1.8
retrieving revision 1.8.34.1
diff -u -d -r1.8 -r1.8.34.1
--- installer.py	19 Feb 2005 22:28:47 -0000	1.8
+++ installer.py	25 Apr 2008 22:01:00 -0000	1.8.34.1
@@ -99,8 +99,9 @@
             destfull = os.path.join(self.tempdir, dest)
 
         # write the copy command
-        project.writeln("\t" + platform.copy.cmd + " " + \
-            self.EscapePath(source) + " " + self.EscapePath(destfull))
+        project.writeln("\t" + platform.copy.cmd + \
+            " \"" + self.EscapePath(source) + "\"" + \
+            " \"" + self.EscapePath(destfull) + "\"")
 
     #######################################################################
     # CopyModuleFile: copies file(s) from source_path in the source root 


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs
[prev in list] [next in list] [prev in thread] [next in thread]