[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] common/util livekeyframe.cpp,1.5,1.5.20.1
From:       jzeng () helixcommunity ! org
Date:       2008-03-28 5:20:28
Message-ID: 200803280520.m2S5Ka3T020582 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/common/util
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv8321/common/util

Modified Files:
      Tag: SERVER_12
	livekeyframe.cpp 
Log Message:
Synopsis
========
Fix realmedia fcs bugs.
Branches:  HEAD, server12, server_12_0
Suggested Reviewer: Jamie 

Description
===========

RV mutiple frames packets have internal timestamp, and we need to
modify them for fcs just as slta does. There is a class
CRVPacketTimeOffsetHandler to do that, but I choose to copy a few
lines over because:

1. that class uses async method of HandlePacket-PacketReady to pass
packets, which will require a major change in baseshim.

2. that class is extremely inefficient unless we rewrite it.  It does
at least 4 strcasecmp for each packets.

In addition, I also add a variable to decide to switch stream. We
can't switch at any switch_off packets: we need to switch at the video
stream.  But The method I used still not work right for multi-rate 3gp
content, and I will address that later.

By the way, I couldn't bear the code in baseshim anymore, so I
refactor it a little bit.

Remaing problems:

1. Now we can switch and the player won't complain anymore. For q=1
switch the playbacks look okay, but for q=0 the player may rebuffer
    and resume playback in a few seconds.

    2. The above-mentioned 3gp multi-rate issue.

    Files Affected
    ==============

    server/common/util/livekeyframe.cpp,v
    server/common/util/pub/livekeyframe.h,v
    server/engine/inputsource/Umakefil,v
    server/engine/inputsource/base_shim.cpp,v
    server/engine/inputsource/mdpshim.cpp,v
    server/engine/inputsource/ppmstaticshim.cpp,v
    server/engine/inputsource/pub/base_shim.h,v
    server/engine/inputsource/pub/mdpshim.h,v
    server/engine/inputsource/pub/ppmstaticshim.h,v
    server/engine/session/clientsession.cpp,v
    server/engine/session/pub/clientsession.h,v
    server-restricted/engine/bin/make_retail,v

    Testing Performed
    =================

    Unit Tests:
    None.

    Integration Tests:
    Test realmedia switching
    Verify 3gp switching still okay.

    Leak Tests:
    --lct 1:1:1 shows no leaks.

    Performance Tests:
    - None

    Platforms Tested: linux-rhel4-i686
    Build verified: linux-rhel4-i686




Index: livekeyframe.cpp
===================================================================
RCS file: /cvsroot/server/common/util/livekeyframe.cpp,v
retrieving revision 1.5
retrieving revision 1.5.20.1
diff -u -d -r1.5 -r1.5.20.1
--- livekeyframe.cpp	10 Apr 2006 19:38:44 -0000	1.5
+++ livekeyframe.cpp	28 Mar 2008 05:20:25 -0000	1.5.20.1
@@ -210,3 +210,11 @@
 
     return FALSE;
 }
+
+BOOL IsRealVideoStream(const char* szMimeType)
+{
+    return  !strcasecmp(szMimeType, REALVIDEO_MIME_TYPE) ||
+            !strcasecmp(szMimeType, REALVIDEO_ENCRYPTED_MIME_TYPE) ||
+            !strcasecmp(szMimeType, REALVIDEO_MULTIRATE_MIME_TYPE) ||
+            !strcasecmp(szMimeType, REALVIDEO_ENCRYPTED_MULTIRATE_MIME_TYPE);
+}


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs
[prev in list] [next in list] [prev in thread] [next in thread]