[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] protocol/rtsp crtspbase.cpp,1.20.2.20,1.20.2.21
From:       stiwary () helixcommunity ! org
Date:       2008-02-28 8:03:28
Message-ID: 200802280804.m1S84H31021832 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/protocol/rtsp
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv11281

Modified Files:
      Tag: SERVER_12
	crtspbase.cpp 
Log Message:


Approved By: Jamie
Branches: Server_12_RN, Head

The same Method onSetUP request was calling FindSession twice to get rid of it Jamie
Suggested to take Session in local pointer & check for session exist & then Chekin. \
By mistake I missed  to merge it in earlier checkin. So, checkin that change again.

Synopsis
========
Fix for PR:213244:Helix Proxy: Variable 'PreferTCP' does not work.
Branch: HEAD , SERVER_12_RN.
Suggested Reviewer: Dean, Anyone

Description
===============

The problem why PreferTCP not getting selected for proxy is that we are
calling  RTSPTransportInstantiator::Init before setting useragent, In the init we are \
initializing m_preferTCP based on condition if m_bUseragentSetting which fails for \
proxy as we have not yet called set useragent. At present it works for server because \
user-agent header is coming in describe request too & from describe request we calls \
handlestream description which calls set useragent for server. But if it will come \
only in setup request then this will fail in server too. That's why we need to call \
setuser agent in base protocol's setup request.


Files Affected
===============
server\protocol\rtsp\crtspbase.cpp

Testing Performed
===============

Functional Tests:
-----------------
Tested the following senario:

Tested with variable PreferTCP & transport get selected is TCP but default is UDP. \
This works fine for server as well as proxy.

Integration Tests:
-----------------

n/a

Leak Tests:
----------

I performed Leak Test on Server as well as Proxy with 3 client. The number of stack \
count on Proxy was one with 52 byte prior as well as after my change. On Server there \
was only one stack of 36 byte before as well as my change.

Performance Tests:
-----------------

n/a


Platforms Tested: win32-i386-vc7

Build Verified: win32-i386-vc7
        

QA Hints
===============

Regards,

Sandeep 

Index: crtspbase.cpp
===================================================================
RCS file: /cvsroot/server/protocol/rtsp/crtspbase.cpp,v
retrieving revision 1.20.2.20
retrieving revision 1.20.2.21
diff -u -d -r1.20.2.20 -r1.20.2.21
--- crtspbase.cpp	28 Feb 2008 07:54:52 -0000	1.20.2.20
+++ crtspbase.cpp	28 Feb 2008 08:02:48 -0000	1.20.2.21
@@ -1948,7 +1948,7 @@
                 IHXMIMEHeader* pTransportMIMEType = 0;
                 rc = HXR_OK;
 
-                if (HXR_OK == pMsg->GetHeader("Transport", pTransportMIMEType))
+                if (HXR_OK == pMsg->GetHeader("Transport", pTransportMIMEType) && \
pClientSession)  {
                     if (!pSessionNew->m_pTransportInstantiator)
                     {


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs


[prev in list] [next in list] [prev in thread] [next in thread]