[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] engine/inputsource mdpshim.cpp,1.5,1.6
From:       rasher () helixcommunity ! org
Date:       2007-12-27 6:22:50
Message-ID: 200712270623.lBR6N0OP016431 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/engine/inputsource
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv1371

Modified Files:
	mdpshim.cpp 
Log Message:
Synopsis
  ==========

 Buffer needs to be Released which creates a memory leak in mdpShim.

 Branches           :  HEAD , SERVER_12_RN
 Suggested Reviewer :  Jamie

   Description
   ============
      In PacketReady after calling AdjustTimeStamp Buffer needs to be
released.

   Files Affected
  ================

   server\engine\inputsource\mdpshim.cpp

   Testing Performed
  =================

 Leak-Tests:
    n/a

Build verified  :win32-i386-vc7
Platforms tested: win32-i386-vc7


 Thanks
 Raj  Asher




Index: mdpshim.cpp
===================================================================
RCS file: /cvsroot/server/engine/inputsource/mdpshim.cpp,v
retrieving revision 1.5
retrieving revision 1.6
diff -u -d -r1.5 -r1.6
--- mdpshim.cpp	24 Dec 2007 20:32:15 -0000	1.5
+++ mdpshim.cpp	27 Dec 2007 06:22:48 -0000	1.6
@@ -137,7 +137,6 @@
         HX_RELEASE(pUberSource);
     }
     StartPackets();
-    
 }
 
 /* IHXServerPacketSource */
@@ -232,6 +231,7 @@
 
     pBuf = ParsePacket(pPacket, ulCurTS);
     pNewPacket = AdjustTimeStamp(pPacket,pBuf);
+    HX_RELEASE(pBuf);
     if (!pNewPacket)
     {
         return HXR_UNEXPECTED;
@@ -242,6 +242,7 @@
     }
     else
     {
+        HX_RELEASE(pNewPacket);
         HX_ASSERT(!"missing m_pPacketSink");
         return HXR_UNEXPECTED;
     }


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs
[prev in list] [next in list] [prev in thread] [next in thread]