[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] engine/session clientsession.cpp,1.79,1.80
From:       dsingh () helixcommunity ! org
Date:       2007-12-27 6:01:00
Message-ID: 200712270601.lBR618Ct015453 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/engine/session
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv15324

Modified Files:
	clientsession.cpp 
Log Message:
Synopsis
========
CR for Bug 210236: FCS Uptime: Solaris: Edge Server: Continuous CAs observed on \
                server
Branch: HEAD, SERVER_12_RN.
Suggested Reviewer: Jamie Gordon.
(already checked in)

Description
===========
The uptime CA was occuring due to redundant deletion of a shared pointer of URL. The \
pointer is being shared by classes ClientSession and CSwitchElement with names m_url \
and m_pSwitchURL respectivaly. Now a copy of the object is being created while \
passing the pointer from CSwitchElement::m_pSwitchURL to ClientSession::m_url.

Files Affected
==============
server/engine/session/clientsession.cpp

Testing Performed
=================
Unit Tests:
- None

Integration Tests:
- Tested with internally built executable for uptime and no CA was observed.

Leak Tests:
- None.

Performance Tests:
- None

Platforms Tested: sunos-5.10-sparc-server.
Build verified: sunos-5.10-sparc-server.

QA Hints
===============
-None



Index: clientsession.cpp
===================================================================
RCS file: /cvsroot/server/engine/session/clientsession.cpp,v
retrieving revision 1.79
retrieving revision 1.80
diff -u -d -r1.79 -r1.80
--- clientsession.cpp	26 Dec 2007 22:11:08 -0000	1.79
+++ clientsession.cpp	27 Dec 2007 06:00:57 -0000	1.80
@@ -3924,6 +3924,7 @@
 #ifdef HELIX_FEATURE_SERVER_FCS
         if(m_pStack->GetSize())
         {
+            HX_DELETE(m_url);
             m_url = pURL;
             HX_RELEASE(m_pRequest);
             m_pRequest = pRequest;
@@ -5264,7 +5265,8 @@
     {
         m_uTestIndex = m_pStack->GetSize() - 1;
         m_bTestDone = 0;
-        OnURL(pSwitchElement->m_pSwitchURL, pSwitchElement->m_pSwitchRequest);
+        URL *pTempURL = new URL(pSwitchElement->m_pSwitchURL);
+        OnURL(pTempURL, pSwitchElement->m_pSwitchRequest);
     }
     return HXR_OK;
 }


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs


[prev in list] [next in list] [prev in thread] [next in thread]