[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] protocol/rtsp crtspbase.cpp,1.20.2.6,1.20.2.7
From:       stiwary () helixcommunity ! org
Date:       2007-12-27 4:46:38
Message-ID: 200712270446.lBR4kjSZ011724 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/protocol/rtsp
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv17362

Modified Files:
      Tag: SERVER_12
	crtspbase.cpp 
Log Message:
Approved By: Jamie
Branches: SERVER_12_RN, HEAD

As per the changes suggested by Jamie I am not removing the Cache-Control Header from \
SETUP response.  The new diff is attached.

Regards,

sandeep

 Jamie Gordon wrote:
 We need to also leave the no-cache in the SETUP response, as that will
 be necessary for any third party caching proxies, etc.

 Thanks,
 Jamie

 Sandeep Tiwary wrote:
 Synopsis
 =============
 This CR include fix for PR:210303:Helix proxy caches FCS connections

 Branches:  HEAD, SERVER_12_RN
 Suggested Reviewer: Jamie

 Description
 =============
 Cache-Control : no-cache header in SETUP response of server to proxy has no effect & \
proxy initiates the cache  chain through MII. But if the Describe response from \
server to proxy contains header Cache-Control : no-cache then  MII doesn't starts the \
caching chain in SETUP request to server & hence it goes to pass through. So, as a \
fix I  added the Cache-Control : no-cache header in the Describe response by removing \
it from SETUP response.

 Files Affected
 =============
 server/protocol/rtsp/crtspbase.cpp

 Testing Performed
 =============
 I tested proxy plays FCS contents through Pass-Trough mode , the same was verified \
by enabling rss as well as  through proxy log. Also switching  works fine.

 Build verified: win32-i386-vc7, linux-rhel4-i686

 Platforms tested: win32-i386-vc7, linux-rhel4-i686


 QA Hints
 =============
 --none


 Regards,

 Sandeep


Index: crtspbase.cpp
===================================================================
RCS file: /cvsroot/server/protocol/rtsp/crtspbase.cpp,v
retrieving revision 1.20.2.6
retrieving revision 1.20.2.7
diff -u -d -r1.20.2.6 -r1.20.2.7
--- crtspbase.cpp	19 Dec 2007 11:54:44 -0000	1.20.2.6
+++ crtspbase.cpp	27 Dec 2007 04:46:36 -0000	1.20.2.7
@@ -7467,6 +7467,9 @@
         {
             pOptionalValues->SetPropertyULONG32("IsFCSSession", 1);
             bIsFCS = TRUE;
+            IHXMIMEHeader* pHeader = new (m_pFastAlloc) CMIMEHeader(m_pFastAlloc);
+            pHeader->SetFromString("Cache-Control","no-cache");
+            m_pRespMsg->AddHeader(pHeader);
         }
 
 #endif //HELIX_FEATURE_SERVER_FCS


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs


[prev in list] [next in list] [prev in thread] [next in thread]