[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-server-cvs
Subject:    [Server-cvs] fs/adminfs adminfo.cpp,1.23,1.24
From:       athakwani () helixcommunity ! org
Date:       2007-10-31 11:18:54
Message-ID: 200710311119.l9VBJ1tW025331 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/server/fs/adminfs
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv20535

Modified Files:
	adminfo.cpp 
Log Message:
Synopsis
========
Fix for PR#206071: Very bad behavior with certain characters in UAS Names

Branches: SERVER_CURRENT_RN
Suggested Reviewer: Darrick

Description
=========== 

Our admin file system was not unescaping the url params properly, this was because in \
AdminInfo::Unescape() method instead of checking nLookAhead char was checking for \
nReplacePos.


Files Affected:
===============
server/fs/adminfs/adminfo.cpp

Testing Performed
=================
Tested UAS Profile names with special character including spaces.
	* Worked as expected.
Platforms tested: linux-rhel4-i686
Build verified: win32-i386-vc7, linux-rhel4-i686

QA Hints
========
None.

Thanks & Regards,
Ashish




Index: adminfo.cpp
===================================================================
RCS file: /cvsroot/server/fs/adminfs/adminfo.cpp,v
retrieving revision 1.23
retrieving revision 1.24
diff -u -d -r1.23 -r1.24
--- adminfo.cpp	17 Sep 2007 04:10:31 -0000	1.23
+++ adminfo.cpp	31 Oct 2007 11:18:51 -0000	1.24
@@ -2249,7 +2249,7 @@
                 nLookAhead += 2;
             }
         }
-        else if (pszIn[nReplacePos] == '+')
+        else if (pszIn[nLookAhead] == '+')
         {
             pszIn[nReplacePos] = ' ';
         }


_______________________________________________
Server-cvs mailing list
Server-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/server-cvs


[prev in list] [next in list] [prev in thread] [next in thread]