[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-protocol-dev
Subject:    [Protocol-dev] RE: [Nokia-private-dev] RE: [datatype-dev] CR:
From:       <ext-debashis.2.panigrahi () nokia ! com>
Date:       2010-08-24 3:26:31
Message-ID: 20D73E2631F7914F868646E119DEC1CE2851FD5072 () NOK-EUMSG-02 ! mgdnok ! nokia ! com
[Download RAW message or body]

Hi,

This is now checked in to 210CayS, 420Bizo and HEAD.

Thanks and Regards,
Debashis.

From: ext Qiang Luo [mailto:qluo@real.com]
Sent: Monday, August 23, 2010 11:38 PM
To: Panigrahi Debashis.2 (EXT-Sasken/Bangalore)
Cc: datatype-dev@helixcommunity.org; protocol-dev@helixcommunity.org; nokia=
-private-dev@helixcommunity.org
Subject: Re: [Nokia-private-dev] RE: [datatype-dev] CR: ou1cimx1#514330: Fu=
sion: System error occurs when streaming a wmv excerpt link.

Looks good.  Qiang

On 8/22/2010 9:19 PM, ext-debashis.2.panigrahi@nokia.com<mailto:ext-debashi=
s.2.panigrahi@nokia.com> wrote:

Hi All,



If there is no comments on this by 23rd Aug EoD, we will go ahead with chec=
k in.



Best Regards,

Debashis.



-----Original Message-----

From: Panigrahi Debashis.2 (EXT-Sasken/Bangalore)

Sent: Tuesday, August 17, 2010 9:14 PM

To: datatype-dev@helixcommunity.org<mailto:datatype-dev@helixcommunity.org>=
; protocol-dev@helixcommunity.org<mailto:protocol-dev@helixcommunity.org>

Cc: nokia-private-dev@helixcommunity.org<mailto:nokia-private-dev@helixcomm=
unity.org>

Subject: RE: [datatype-dev] CR: ou1cimx1#514330: Fusion: System error occur=
s when streaming a wmv excerpt link.



Any comments on this?



BR,

Debashis

________________________________________

From: datatype-dev-bounces@helixcommunity.org<mailto:datatype-dev-bounces@h=
elixcommunity.org> [datatype-dev-bounces@helixcommunity.org<mailto:datatype=
-dev-bounces@helixcommunity.org>] On Behalf Of Panigrahi Debashis.2 (EXT-Sa=
sken/Bangalore)

Sent: 16 August 2010 11:22

To: datatype-dev@helixcommunity.org<mailto:datatype-dev@helixcommunity.org>=
; protocol-dev@helixcommunity.org<mailto:protocol-dev@helixcommunity.org>

Cc: nokia-private-dev@helixcommunity.org<mailto:nokia-private-dev@helixcomm=
unity.org>

Subject: [datatype-dev] CR: ou1cimx1#514330: Fusion: System error occurs wh=
en streaming a wmv excerpt link.



"Nokia submits this code under the terms of a commercial contribution agree=
ment with Real Networks, and I am authorized to contribute this code under =
said agreement."



Modified by:  ext-debashis.2.panigrahi@nokia.com<mailto:ext-debashis.2.pani=
grahi@nokia.com>



Reviewed by:  Junhong.Liu@nokia.com<mailto:Junhong.Liu@nokia.com>



RC Id: ou1cimx1#514330



Date: 08/16/2010



Project: SymbianMmf_wm



Synopsis: Fusion: System error occurs when streaming a wmv excerpt link.



Overview:

The content here is a dynamic link, which causes seek to be called before p=
lay has started. Whereas there is no provision to handle such as state/ con=
dition in wm protocol. Therefore when HXMSG_WMNET_BEGIN_SELECT_STREAMS mess=
age is issued, it fails with HXR_UNEXPECTED and this systematically gets pr=
opagated as "System Error"



Fix:

To handle such a condition a new state has been introduced here "kThreadSta=
teEndSelectStreamsPendingFromSeeked". So when ThreadHandleBeginSelectStream=
s(.) is called after SeekDone, this new state captures the state transition=
. Then causes the Play to defer till ThreadHandleEndSelectStreams(.) is cal=
led, thereby causing the playback to start from the seeked position.



Files modified & changes:

wmcode-protocol/rtsp/fileformat/asf_file_format_net.cpp

wmcode-protocol/rtsp/fileformat/pub/asf_file_format_net.h



Image Size and Heap Use impact: No major impact



Module Release testing (STIF) : Passed



Test case(s) Added  : No



Memory leak check performed : Passed, No additional leaks introduced.



Platforms and Profiles Build Verified: helix-client-s60-52-mmf-mdf-dsp



Platforms and Profiles Functionality verified: armv5, winscw



Branch: 210CayS, 420Bizo and HEAD



CVS Diff on 210CayS: <Attached>


[Attachment #3 (text/html)]

<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40">

<head>
<meta http-equiv=Content-Type content="text/html; charset=us-ascii">
<meta name=Generator content="Microsoft Word 12 (filtered medium)">
<style>
<!--
 /* Font Definitions */
 @font-face
	{font-family:Calibri;
	panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
	{font-family:Tahoma;
	panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
	{font-family:Consolas;
	panose-1:2 11 6 9 2 2 4 3 2 4;}
 /* Style Definitions */
 p.MsoNormal, li.MsoNormal, div.MsoNormal
	{margin:0in;
	margin-bottom:.0001pt;
	font-size:12.0pt;
	font-family:"Times New Roman","serif";
	color:black;}
a:link, span.MsoHyperlink
	{mso-style-priority:99;
	color:blue;
	text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
	{mso-style-priority:99;
	color:purple;
	text-decoration:underline;}
pre
	{mso-style-priority:99;
	mso-style-link:"HTML Preformatted Char";
	margin:0in;
	margin-bottom:.0001pt;
	font-size:10.0pt;
	font-family:"Courier New";
	color:black;}
span.HTMLPreformattedChar
	{mso-style-name:"HTML Preformatted Char";
	mso-style-priority:99;
	mso-style-link:"HTML Preformatted";
	font-family:Consolas;
	color:black;}
span.EmailStyle19
	{mso-style-type:personal-reply;
	font-family:"Calibri","sans-serif";
	color:#1F497D;}
.MsoChpDefault
	{mso-style-type:export-only;
	font-size:10.0pt;}
@page WordSection1
	{size:8.5in 11.0in;
	margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
	{page:WordSection1;}
-->
</style>
<!--[if gte mso 9]><xml>
 <o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
 <o:shapelayout v:ext="edit">
  <o:idmap v:ext="edit" data="1" />
 </o:shapelayout></xml><![endif]-->
</head>

<body bgcolor=white lang=EN-US link=blue vlink=purple>

<div class=WordSection1>

<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Hi,<o:p></o:p></span></p>

<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p>&nbsp;</o:p></span></p>

<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>This is now checked in to 210CayS, 420Bizo and \
HEAD.<o:p></o:p></span></p>

<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p>&nbsp;</o:p></span></p>

<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Thanks and Regards,<o:p></o:p></span></p>

<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'>Debashis.<o:p></o:p></span></p>

<p class=MsoNormal><span style='font-size:11.0pt;font-family:"Calibri","sans-serif";
color:#1F497D'><o:p>&nbsp;</o:p></span></p>

<div>

<div style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in'>

<p class=MsoNormal><b><span \
style='font-size:10.0pt;font-family:"Tahoma","sans-serif"; \
color:windowtext'>From:</span></b><span style='font-size:10.0pt;font-family: \
"Tahoma","sans-serif";color:windowtext'> ext Qiang Luo [mailto:qluo@real.com] <br> \
<b>Sent:</b> Monday, August 23, 2010 11:38 PM<br> <b>To:</b> Panigrahi Debashis.2 \
(EXT-Sasken/Bangalore)<br> <b>Cc:</b> datatype-dev@helixcommunity.org; \
protocol-dev@helixcommunity.org; nokia-private-dev@helixcommunity.org<br>
<b>Subject:</b> Re: [Nokia-private-dev] RE: [datatype-dev] CR: ou1cimx1#514330:
Fusion: System error occurs when streaming a wmv excerpt link.<o:p></o:p></span></p>

</div>

</div>

<p class=MsoNormal><o:p>&nbsp;</o:p></p>

<p class=MsoNormal>Looks good.&nbsp; Qiang<br>
<br>
On 8/22/2010 9:19 PM, <a \
href="mailto:ext-debashis.2.panigrahi@nokia.com">ext-debashis.2.panigrahi@nokia.com</a>
                
wrote: <o:p></o:p></p>

<pre>Hi All,<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>If there is no comments \
on this by 23rd Aug EoD, we will go ahead with check \
in.<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>Best \
Regards,<o:p></o:p></pre><pre>Debashis.<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>-----Original \
Message-----<o:p></o:p></pre><pre>From: Panigrahi Debashis.2 (EXT-Sasken/Bangalore) \
<o:p></o:p></pre><pre>Sent: Tuesday, August 17, 2010 9:14 PM<o:p></o:p></pre><pre>To: \
<a href="mailto:datatype-dev@helixcommunity.org">datatype-dev@helixcommunity.org</a>; \
<a href="mailto:protocol-dev@helixcommunity.org">protocol-dev@helixcommunity.org</a><o:p></o:p></pre><pre>Cc: \
<a href="mailto:nokia-private-dev@helixcommunity.org">nokia-private-dev@helixcommunity.org</a><o:p></o:p></pre><pre>Subject: \
RE: [datatype-dev] CR: ou1cimx1#514330: Fusion: System error occurs when streaming a \
wmv excerpt link.<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>Any comments on \
this?<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>BR,<o:p></o:p></pre><pre>Debash \
is<o:p></o:p></pre><pre>________________________________________<o:p></o:p></pre><pre>From: \
<a href="mailto:datatype-dev-bounces@helixcommunity.org">datatype-dev-bounces@helixcommunity.org</a> \
[<a href="mailto:datatype-dev-bounces@helixcommunity.org">datatype-dev-bounces@helixcommunity.org</a>] \
On Behalf Of Panigrahi Debashis.2 (EXT-Sasken/Bangalore)<o:p></o:p></pre><pre>Sent: \
16 August 2010 11:22<o:p></o:p></pre><pre>To: <a \
href="mailto:datatype-dev@helixcommunity.org">datatype-dev@helixcommunity.org</a>; <a \
href="mailto:protocol-dev@helixcommunity.org">protocol-dev@helixcommunity.org</a><o:p></o:p></pre><pre>Cc: \
<a href="mailto:nokia-private-dev@helixcommunity.org">nokia-private-dev@helixcommunity.org</a><o:p></o:p></pre><pre>Subject: \
[datatype-dev] CR: ou1cimx1#514330: Fusion: System error occurs when streaming a wmv \
excerpt link.<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>&quot;Nokia submits \
this code under the terms of a commercial contribution agreement with Real Networks, \
and I am authorized to contribute this code under said \
agreement.&quot;<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>Modified by:&nbsp; \
<a href="mailto:ext-debashis.2.panigrahi@nokia.com">ext-debashis.2.panigrahi@nokia.com</a><o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>Reviewed \
by:&nbsp; <a href="mailto:Junhong.Liu@nokia.com">Junhong.Liu@nokia.com</a><o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>RC \
Id: ou1cimx1#514330<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>Date: \
08/16/2010<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>Project: \
SymbianMmf_wm<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>Synopsis: Fusion: \
System error occurs when streaming a wmv excerpt \
link.<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>Overview:<o:p></o:p></pre><pre>The \
content here is a dynamic link, which causes seek to be called before play has \
started. Whereas there is no provision to handle such as state/ condition in wm \
protocol. Therefore when HXMSG_WMNET_BEGIN_SELECT_STREAMS message is issued, it fails \
with HXR_UNEXPECTED and this systematically gets propagated as &quot;System \
Error&quot;<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>Fix:<o:p></o:p></pre><pre>To \
handle such a condition a new state has been introduced here \
&quot;kThreadStateEndSelectStreamsPendingFromSeeked&quot;. So when \
ThreadHandleBeginSelectStreams(.) is called after SeekDone, this new state captures \
the state transition. Then causes the Play to defer till \
ThreadHandleEndSelectStreams(.) is called, thereby causing the playback to start from \
the seeked position.<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>Files modified \
&amp; changes:<o:p></o:p></pre><pre>wmcode-protocol/rtsp/fileformat/asf_file_format_ne \
t.cpp<o:p></o:p></pre><pre>wmcode-protocol/rtsp/fileformat/pub/asf_file_format_net.h<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>Image \
Size and Heap Use impact: No major \
impact<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>Module Release testing (STIF) \
: Passed<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>Test case(s) Added&nbsp; : \
No<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>Memory leak check performed : \
Passed, No additional leaks \
introduced.<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>Platforms and Profiles \
Build Verified: helix-client-s60-52-mmf-mdf-dsp<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>Platforms \
and Profiles Functionality verified: armv5, \
winscw<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>Branch: 210CayS, 420Bizo and \
HEAD<o:p></o:p></pre><pre><o:p>&nbsp;</o:p></pre><pre>CVS Diff on 210CayS: \
&lt;Attached&gt;<o:p></o:p></pre>

<p class=MsoNormal><o:p>&nbsp;</o:p></p>

</div>

</body>

</html>



_______________________________________________
Protocol-dev mailing list
Protocol-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/protocol-dev

--===============1523971625==--


[prev in list] [next in list] [prev in thread] [next in thread] 

Configure | About | News | Add a list | Sponsored by KoreLogic