[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-protocol-dev
Subject:    RE: [Protocol-dev] CR needed: ou1cimx1#507933 - Crash occurs when
From:       <Yury.Ramanovich () nokia ! com>
Date:       2010-08-10 19:19:27
Message-ID: BE808F92D8B85A4FB9A6D26B46CB39EC2CFB0D3571 () NOK-EUMSG-03 ! mgdnok ! nokia ! com
[Download RAW message or body]

Thanks. Checked in to 420Brizo and HEAD

BR
Yury

>-----Original Message-----
>From: ext Sheldon Fu [mailto:sfu@real.com]
>Sent: Monday, August 09, 2010 10:25 PM
>To: Ramanovich Yury (Nokia-MS/Dallas)
>Cc: protocol-dev@helixcommunity.org
>Subject: Re: [Protocol-dev] CR needed: ou1cimx1#507933 - Crash occurs
>when trying to play a ram file containing a streaming link but server is
>not valid
>
>Looks good.
>
>fxd
>
>Yury.Ramanovich@nokia.com wrote:
>> Modified by:  _yury.ramanovich@nokia.com_
>> <mailto:yury.ramanovich@nokia.com>
>>
>> Reviewed by:
>>
>> Date: 08/09/2010
>>
>> Project: symbianMmf_wm
>>
>> ErrorId: ou1cimx1#507933
>>
>> Synopsis: Crash occurs when trying to play a ram file containing a
>> streaming link but server is not valid.
>>
>> Overview: when trying to stream an rtsp link pointing to "invalid
>> server", there are 3 transport switches happen before helix closes.
>> Helix does send KerrCouldNotConnect to UI, but eventually crashes. The
>> reason for the crash is several (3) unreleased references to
>> HXClientEngine and other objects. RTSPClientSession socket was not
>> closed when session failed. This caused 2 RTSPClientSession objects
>> which hold refs to HXClientEngine not to be destroyed and HXNetSource
>> object which also holds a reference to HXClientEngine was not
>destroyed.
>>
>> Solution: close socket if session is failed in
>> RTSPClientSession::ConnectDone()
>>
>> Files Added:
>> None.
>>
>> Files Modified:
>> \protocol\rtsp\rtspclnt.cpp
>>
>>
>> Index: rtspclnt.cpp
>> ===================================================================
>> RCS file: /cvsroot/protocol/rtsp/rtspclnt.cpp,v
>> retrieving revision 1.245.4.4
>> diff -u -w -r1.245.4.4 rtspclnt.cpp
>> --- rtspclnt.cpp        6 Aug 2010 11:05:37 -0000       1.245.4.4
>> +++ rtspclnt.cpp        9 Aug 2010 15:34:56 -0000
>> @@ -1563,6 +1563,7 @@
>>                  pInfo->m_pProt->SessionFailed(this, m_pSocket);
>>              }
>>          }
>> +        closeSocket();
>>      }
>>
>>      HX_RELEASE(m_pConnectingProt);
>>
>>
>>
>>
>> Image Size and Heap Use impact: minor
>>
>> Module Release testing : STIF passed.
>>
>> Test case(s) Added  :  No.
>>
>> Memory leak check performed : Yes. No new leaks introduced
>>
>> Platforms and Profiles Build Verified:
>> helix-client-s60-52-mmf-mdf-dsp
>>
>> Platforms and Profiles Functionality verified: armv5
>>
>> Branch: 420Brizo, HEAD.
>>
>>
>> BR
>> Yury
>>
>>


_______________________________________________
Protocol-dev mailing list
Protocol-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/protocol-dev

[prev in list] [next in list] [prev in thread] [next in thread]