[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-protocol-dev
Subject:    [Protocol-dev] RESEND CR: EADV-7XGMD9 : Sound is not played any
From:       <ext-debashis.2.panigrahi () nokia ! com>
Date:       2010-02-26 14:00:54
Message-ID: 20D73E2631F7914F868646E119DEC1CE2240575EF8 () NOK-EUMSG-02 ! mgdnok ! nokia ! com
[Download RAW message or body]

Any comments on this?

BR,
Debashis. 

-----Original Message-----
From: Panigrahi Debashis.2 (EXT-Sasken/Bangalore) 
Sent: Thursday, February 25, 2010 6:52 PM
To: 'protocol-dev@helixcommunity.org'
Cc: nokia-private-dev@helixcommunity.org
Subject: CR: EADV-7XGMD9 : Sound is not played any more after streaming video is \
scrolled

"Nokia submits this code under the terms of a commercial contribution agreement with \
RealNetworks, and I am authorized to contribute this code under said agreement."  
Modified by:  ext-debashis.2.panigrahi@nokia.com
 
Reviewed by:  Junhong.Liu@nokia.com
 
TSW Id: EADV-7XGMD9
 
Date: 02/25/2010
	 
Project: SymbianMmf_wm
 
Synopsis: Sound is not played any more after streaming video is scrolled
 
Overview:
In this case the sequence number (SQN) sent by the server just before seek is same as \
the one after seek. Helix increments the SQN in UpdateStatsFromPacket () but gets a \
SQN which is lower than this value and so goes on Flushing-Getting Packets.

Fix:
The Solution here is to set the first sequence number equal to the one we get in play \
response. Setting the first sequence number at the initialization of transport buffer \
after we get a play response.

Files modified & changes:
protocol\transport\common\system\transbuf.cpp

Image Size and Heap Use impact: No major impact
 
Module Release testing (STIF) : Passed
 
Test case(s) Added  : No

Memory leak check performed : Passed, No additional leaks introduced.
 
Platforms and Profiles Build Verified: helix-client-s60-50-mmf-mdf-dsp
 
Platforms and Profiles Functionality verified: armv5, winscw
 
Branch: 210CayS, 223CayS, 420Bizo and HEAD

CVS Diff on 210CayS:

Index: transbuf.cpp
===================================================================
RCS file: /cvsroot/protocol/transport/common/system/transbuf.cpp,v
retrieving revision 1.27.2.4
diff -u -w -r1.27.2.4 transbuf.cpp
--- transbuf.cpp        8 Jan 2007 17:27:36 -0000       1.27.2.4
+++ transbuf.cpp        23 Feb 2010 06:28:13 -0000
@@ -345,6 +345,13 @@
             return HXR_OK;
         }

+        //This is resilience against the condition when SQN before seek is
+        //same as after seek. Only allow the first sequence number to be set
+        //if SQN sent is less than equal to First SQN and Seek has been done.
+        if (m_uFirstSequenceNumber > uSeqNo)
+        {
+            m_uFirstSequenceNumber = uSeqNo;
+        }
         m_uSeekSequenceNumber = uSeqNo;
         m_bWaitingForSeekFlush = TRUE;
     }
_______________________________________________
Protocol-dev mailing list
Protocol-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/protocol-dev


[prev in list] [next in list] [prev in thread] [next in thread]