'[Protocol-dev] RESEND: CR: EJVZ-7YB559 Incorrect output msg'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-protocol-dev
Subject:    [Protocol-dev] RESEND: CR: EJVZ-7YB559 Incorrect output msg
From:       "Rodriguez Jesus.1 (EXT-DextraTechnologies/Mexico)"
Date:       2010-01-04 18:29:12
Message-ID: C29712E9-4A32-4649-8464-F91A848A9CB2 () mimectl
[Download RAW message or body]

[Attachment #2 (text/html)]

<HTML dir=ltr><HEAD></HEAD>
<BODY>
<DIV dir=ltr id=idOWAReplyText65518>
<DIV dir=ltr><FONT color=#000000 size=2 face=Arial>Hi all; any feedback&nbsp;on \
this?</FONT></DIV></DIV> <DIV dir=ltr><BR>
<HR tabIndex=-1>
<FONT size=2 face=Tahoma><B>From:</B> ext Rodriguez Jesus.1 \
(EXT-DextraTechnologies/Mexico)<BR><B>Sent:</B> Tue 2009-12-22 11:24<BR><B>To:</B> \
protocol-dev@helixcommunity.org; \
nokia-private-dev@helixcommunity.org<BR><B>Subject:</B> [Nokia-private-dev] CR: \
EJVZ-7YB559 Incorrect output msg "System: System Error" instead of "Invalid \
Clip"<BR></FONT><BR></DIV> <DIV dir=ltr>
<DIV dir=ltr id=idOWAReplyText6541>
<DIV dir=ltr><FONT color=#000000 size=2 face=Arial><EM>"Nokia submits this code under \
the terms of a commercial contribution agreement with Real Networks, and I am \
authorized to contribute this code under said agreement."</EM><BR><BR>Modified by: <A \
href="mailto:ext-jesus.1.rodriguez@nokia.com" \
target=_blank>ext-jesus.1.rodriguez@nokia.com</A></FONT><FONT color=#000000 size=2 \
face=Arial><BR>Reviewed by: <A href="mailto:ashish.as.gupta@nokia.com" \
target=_blank>ashish.as.gupta@nokia.com</A></FONT></DIV></DIV> <DIV dir=ltr>
<DIV dir=ltr>
<DIV><FONT color=#000000><FONT size=2 face=Arial>Date: Dec 17, 2009<BR>Project: \
SymbianMmf_wm<BR>ErrorId: EJVZ-7YB559<BR>Synopsis: Incorrect output msg "System: \
System Error" instead of "Invalid Clip"</FONT></FONT></DIV> <DIV><FONT \
color=#000000><FONT size=2 face=Arial>&nbsp;</DIV></FONT></FONT> <DIV><FONT \
color=#000000><FONT size=2 face=Arial>Overview:<BR>When opening an invalid SDP file, \
Helix returns HXR_FAIL to its top-level client, instead of a more meaningful error \
code.</FONT></FONT></DIV> <DIV><FONT color=#000000><FONT size=2 \
face=Arial><BR>Solution:<BR>On RTSPClientProtocol::ParseSDP, if the SDP parser \
returns HXR_FAIL, change the return code to HXR_SE_DATATYPE_UNSUPPORTED, for the \
top-level client to have a more accurate idea of what happened. I did not make this \
change inside the SDP parser because I felt its error codes only have meaning \
internally -for the current parser state, for example- and are not really meant to be \
bubbled up to the TLC by themselves.<BR><BR>Modified \
files:<BR>/protocol/rtsp/rtspclnt.cpp</FONT></FONT></DIV> <DIV><FONT \
color=#000000><FONT size=2 face=Arial><BR>New files: None<BR>Image size and heap use \
impact: Negligible<BR>Module Release testing (STIF): Yes<BR>Test case(s) added: \
None<BR>Memory leak check performed: Yes, no new leaks introduced.<BR>Platforms and \
Profiles Build verified: helix-client-s60-52-mmf-mdf-dsp, \
helix-client-s60-50-mmf-mdf-arm<BR>Platforms and Profiles Functionality verified: \
armv5<BR>Branch: 221Cays, 223Cays, 210Cays, 420Brizo, \
HEAD<BR></DIV></FONT></FONT></DIV></DIV></DIV></BODY></HTML>


["protocol.diff" (application/octet-stream)]

? common/util/Makefile
? common/util/Umakefil.upp
? common/util/armv5-rel32
? http/Makefile
? http/Umakefil.upp
? http/armv5-rel32
? rtsp/Makefile
? rtsp/Umakefil.upp
? rtsp/armv5-rel32
? sdp/Makefile
? sdp/Umakefil.upp
? sdp/armv5-rel32
? sdp/hxsdp_dll_stub.c
? sdp/hxsdp_ordinal.dat
? sdp/hxsdp{000a0000}.def
? sdp/sdplib.mak
? sdp/sdplib.upp
? sdp/sdpplin.mak
? sdp/sdpplin.upp
? transport/common/system/Makefile
? transport/common/system/Umakefil.upp
? transport/common/system/armv5-rel32
? transport/rdt/Makefile
? transport/rdt/Umakefil.upp
? transport/rdt/armv5-rel32
? transport/rtp/Makefile
? transport/rtp/Umakefil.upp
? transport/rtp/armv5-rel32
Index: rtsp/rtspclnt.cpp
===================================================================
RCS file: /cvsroot/protocol/rtsp/rtspclnt.cpp,v
retrieving revision 1.182.2.40.4.3
diff -u -w -r1.182.2.40.4.3 rtspclnt.cpp

--- rtsp/rtspclnt.cpp	20 Oct 2009 19:27:14 -0000	1.182.2.40.4.3
+++ rtsp/rtspclnt.cpp	17 Dec 2009 16:44:28 -0000
@@ -10488,6 +10488,14 @@
     {
         // error
         HX_ASSERT(!"bad sdp file 0");
+
+        // If the error code that is bubbled to the top-level client
+        // is too generic, it may be unable to display 
+        // a suitable message to the end user.
+        if( HXR_FAIL == rc )
+        {
+            rc = HXR_SE_DATATYPE_UNSUPPORTED;
+        }
     }
     else if (nValues <= 1)
     {


_______________________________________________
Protocol-dev mailing list
Protocol-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/protocol-dev


[prev in list] [next in list] [prev in thread] [next in thread] 
