[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-protocol-cvs
Subject:    [Protocol-cvs] transport/common/system/pub rtspif.h,1.27,1.28
From:       vijshetty () helixcommunity ! org
Date:       2004-12-08 17:45:06
[Download RAW message or body]

Update of /cvsroot/protocol/transport/common/system/pub
In directory cvs-new:/tmp/cvs-serv17379

Modified Files:
	rtspif.h 
Log Message:
fixes PR 130232 "Seek broken when using RTP transport". Problem was caused by server \
sending incomplete RTP info in PLAY response as a result of the Player Session not \
been set to require RTPInfo. This is fixed by the change listed in item 1 below.

1.> RTSPServerProtocol changed to use m_pbSETUPRcvdStrm[] to decide if a stream has \
been SETUP. The flag used earlier was not initialized and is also redundant and hence \
was removed. 2.> fixes a probable typo in RTSPServerProtocol::SetStreamStartTime(). \
The conditional statement used to decide if Play response can be send was checking \
m_bRangeResponsePending twice instead of m_bRangeResponsePending and \
m_bRTPInfoResponsePending. This did not introduce problems in earlier versions \
because the subsequent method used to send play response does the right checks.

Files Affected
==============
protocol/transport/common/system/pub/rtspif.h
server/protocol/rtsp/rtspserv.cpp

Testing Performed
=================
Unit Tests:
tracked the RTSP conversation to ensure that valid RTPInfo is sent in PLAY response

Integration Tests:
tested single and multirate on-demand 3gp content with RTP/TCP and RTP/UDP with \
MDP/PPM.

Seek worked as expected and the Player renders content but there are playout issues \
in certain cases and I'll file a seperate PR to resolve that.

Reviewed by: Go Hori, Damon Lanphear


Index: rtspif.h
===================================================================
RCS file: /cvsroot/protocol/transport/common/system/pub/rtspif.h,v
retrieving revision 1.27
retrieving revision 1.28
diff -u -d -r1.27 -r1.28
--- rtspif.h	6 Dec 2004 18:04:50 -0000	1.27
+++ rtspif.h	8 Dec 2004 17:45:04 -0000	1.28
@@ -221,7 +221,6 @@
         , m_pMulticastAddr(NULL)
         , m_bRealMedia(FALSE)
         , m_uStreamGroupNumber(0xFFFF)
-        , m_bSetupReceived(FALSE)
     {}
 
     _RTSPStreamInfo::~_RTSPStreamInfo()
@@ -257,7 +256,6 @@
     UINT32      m_ulRtpRSBitRate;
     IHXSockAddr* m_pMulticastAddr;
     BOOL        m_bRealMedia;
-    BOOL        m_bSetupReceived;
 } RTSPStreamInfo;
 
 typedef struct _RTSPSocketInfo


[prev in list] [next in list] [prev in thread] [next in thread]