[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-player-dev
Subject:    [Player-dev] CN: BUG 10071 Crash after deleting file from "My
From:       Chris Young <chrisy () real ! com>
Date:       2010-07-16 18:18:45
Message-ID: 4C40A285.5020308 () real ! com
[Download RAW message or body]

This is a MIME-formatted message.  If you see this text it means that your
E-mail software does not support MIME-formatted messages.


  new revision: 1.3.16.1.24.1; previous revision: 1.3.16.1

-- 

Chris Young
chrisy@real.com


["cr" (text/plain)]

Subject: CR: BUG 10071 Crash after deleting file from "My Library"
Modified by: chrisy@real.com
Date: 07:13:10
Project: 
Bug Number: 10071
Bug URL: https://bugs.helixcommunity.org/show_bug.cgi?id=10071

Synopsis: This may fix the aforementioned bug. Fixed copy/paste "typo"

Overview: change *iter to the appropriate value while iterating through elements
 
Files Modified:
common/log/logcommon/hlxxmlparser.cpp

Platforms and Profiles Build Verified:
SYSTEM_ID=linux-2.2-libc6-gcc32-i586
HELIX_BRANCH=realplay_gtk_atlas_restricted_gold_1.2
PROFILE_ID=helix-client-moblin
TARGET=mediasinkplayer

Branch: hxclient_3_4_10_atlas

Copyright assignment:  I am a RealNetworks employee or contractor

QA Instructions:

["patch" (text/plain)]

Index: common/log/logcommon/hlxxmlparser.cpp
===================================================================
RCS file: /cvsroot/common/log/logcommon/hlxxmlparser.cpp,v
retrieving revision 1.3.16.1
diff -C 5 -w -r1.3.16.1 hlxxmlparser.cpp
*** common/log/logcommon/hlxxmlparser.cpp	13 Sep 2008 03:50:30 -0000	1.3.16.1
--- common/log/logcommon/hlxxmlparser.cpp	13 Jul 2010 20:50:44 -0000
***************
*** 351,361 ****
      }
  
      CHXPtrArray::Iterator ElementIter;
      for(ElementIter = m_vChildElements.Begin(); ElementIter != \
m_vChildElements.End(); ++ElementIter)  {
!         CHXTElement* pElem = (CHXTElement*)*iter;
          HX_DELETE(pElem);
      }
  }
  
  
--- 351,361 ----
      }
  
      CHXPtrArray::Iterator ElementIter;
      for(ElementIter = m_vChildElements.Begin(); ElementIter != \
m_vChildElements.End(); ++ElementIter)  {
!         CHXTElement* pElem = (CHXTElement*)*ElementIter;
          HX_DELETE(pElem);
      }
  }
  
  
***************
*** 373,383 ****
      }
  
      CHXPtrArray::Iterator ElementIter;
      for(ElementIter = rhs_.m_vChildElements.Begin(); ElementIter != \
rhs_.m_vChildElements.End(); ++ElementIter)  {
!         CHXTElement* pElem = (CHXTElement*)*iter;
          CHXTElement* pElemClone = new CHXTElement(*pElem);
          m_vChildElements.Add(pElemClone);
      }
  
      return *this;
--- 373,383 ----
      }
  
      CHXPtrArray::Iterator ElementIter;
      for(ElementIter = rhs_.m_vChildElements.Begin(); ElementIter != \
rhs_.m_vChildElements.End(); ++ElementIter)  {
!         CHXTElement* pElem = (CHXTElement*)*ElementIter;
          CHXTElement* pElemClone = new CHXTElement(*pElem);
          m_vChildElements.Add(pElemClone);
      }
  
      return *this;



_______________________________________________
Player-dev mailing list
Player-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/player-dev


[prev in list] [next in list] [prev in thread] [next in thread]