[prev in list] [next in list] [prev in thread] [next in thread]
List: helix-player-dev
Subject: Re: [Player-dev] CR/CN: Fix for Bug 9049: Cannot seek
From: "Sushant Garg" <sgarg () real ! com>
Date: 2009-01-14 4:48:47
Message-ID: 008b01c97601$b80d8b30$0701a8c0 () sushant
[Download RAW message or body]
Also checked in to Atlas347.
Thanks & Regards
Sushant Garg
----- Original Message -----
From: "Sushant Garg" <sgarg@real.com>
To: <player-dev@helixcommunity.org>
Sent: Friday, December 19, 2008 12:03 PM
Subject: [Player-dev] CR/CN: Fix for Bug 9049: Cannot seek
withinlivestreambuffer
Project: RealPlayer for Netbook
Synopsis: Fix for Bug 9049: Cannot seek within livestream buffer.
Overview:
Currently, while playing a live stream and Enabling Perfect Play, if a User
tried to seek back in the player buffer region, the resulting behavior is
that the player slider jumps to the rightmost region in the progress bar.
This is due to the fact that "LiveSuperBuffer" was not getting set in the
preferences and due to which a Live stream was not supporting any SEEK.
Now we had uncommented the changes done by Liteplayer team (only for
Atlas346 branch) & so preferences of
LiveSuperBuffer is set to 1.
Files Modified:
player/hxclientkit/src/hxrecordengine/CHXClientRecordService.cpp
Image Size and Heap Use impact (Client -Only):
None.
Platforms and Profiles Affected:
Linux
Distribution Libraries Affected:
None.
Distribution library impact and planned action:
None.
Platforms and Profiles Build Verified:
Profile: helix-client-moblin
Target: player_all
BIF: realplay_gtk_atlas_restricted_gold
Branch:
Atlas346
Files Attached:
diff.txt
Thanks & Regards
Sushant Garg
----- Original Message -----
From: "Sushant Garg" <sgarg@real.com>
To: "Daniel Yek" <dyek@real.com>
Cc: <player-dev@helixcommunity.org>
Sent: Thursday, December 04, 2008 2:41 PM
Subject: Re: [Player-dev] CR: Fix for Bug 9049: Cannot seek within
livestreambuffer
In CHXClientRecordService::Init() function in CHXClientRecordService.cpp,
setting "LiveSuperBuffer" is being disabled:
// Set the "LiveSuperBuffer" to "1"; otherwise, Helix will ignore
seeking within a live stream.
if ( gNumOfActiveRecordServiceObjects == 1 )
{
// XXX HP: why do we need to alter the preference!!
// It's set by the application and we should just honor it.
//SetBoolPreference( Pref_LiveSuperBuffer, true );
}
Now, its being mentioned that it is set by application, so for our Netbook
application, we are setting it separately in hxplayer.cpp.
Let me know your thoughts on this.
Thanks & Regards
Sushant Garg
----- Original Message -----
From: "Daniel Yek" <dyek@real.com>
To: "Sushant Garg" <sgarg@real.com>
Cc: <player-dev@helixcommunity.org>
Sent: Thursday, December 04, 2008 1:58 PM
Subject: Re: [Player-dev] CR: Fix for Bug 9049: Cannot seek within
livestream buffer
> Hi Sushant,
>
> Good job in finding out that it is LiveSuperBuffer Preference that isn't
> set properly.
>
> I think the change should happen in hxclientkit though.
>
> Please refer to the following CRs to get a hint of where is the right
> place to fix this.
>
> hxrecordengine (Superbuffer) info.:
> http://lists.helixcommunity.org/pipermail/player-dev/2007-December/003252.html
> Implementing Superbuffer Preference dialog options:
> http://lists.helixcommunity.org/pipermail/player-dev/2007-December/003253.html
>
> Please look into this file:
> player/hxclientkit/src/hxrecordengine/CHXClientRecordService.cpp
>
> I think the original hxclientkit developers, changed how Superbuffer
> Enabling/Disabling Preferences work from RealPlayer for Windows.
> RealPlayer for Linux team again decided to use the "unified" function call
> approach, instead of individual Preferences.
> I learned, after the fact from the CVS, that the LitePlayer project
> reverted hxclientkit (on 310Atlas) to use the Preference the Windows
> style.
> RealPlayer for Netbook, in turn, inherited hxclientkit on 310Atlas and
> thus is using the logic changed by the LitePlayer team, which probably
> doesn't work for our GUI layer.
> That is just a bit of the effect of lack of communication and clear
> direction and decisions that have to be made instantaneously.
>
> I think we probably should at least change hxclientkit back to what
> RealPlayer for Linux expected (copy or port from 150Cay branch) in our
> product branch and eventually find a way to make 310Atlas work for both
> teams.
>
> Let me know if I'm mistaken by just reading the diff...
>
> --
> Daniel Yek.
>
>
>
> Sushant Garg wrote:
>> Project: RealPlayer for Netbook
>>
>>
>>
>> Synopsis: Fix for Bug 9049: Cannot seek within livestream buffer.
>>
>>
>>
>> Overview:
>>
>>
>>
>> Currently, while playing a live stream and Enabling Perfect Play, if a
>> User tried to seek back in the player buffer region, the resulting
>> behavior is that the player slider jumps to the rightmost region in the
>> progress bar.
>>
>>
>>
>> This is due to the fact that "LiveSuperBuffer" was not getting set in the
>> preferences and due to which a Live stream was not supporting any SEEK.
>>
>>
>>
>> Now that preference has been set and we are able to SEEK live streams
>> during PerfectPlay.
>>
>>
>>
>> Files Modified:
>>
>> player/common/gtk/hxplayer.cpp
>>
>>
>>
>> Image Size and Heap Use impact (Client -Only):
>>
>> None.
>>
>>
>>
>> Platforms and Profiles Affected:
>>
>> Linux
>>
>>
>>
>> Distribution Libraries Affected:
>>
>> None.
>>
>>
>>
>> Distribution library impact and planned action:
>>
>> None.
>>
>>
>>
>> Platforms and Profiles Build Verified:
>>
>> Profile: helix-client-moblin
>>
>> Target: player_all
>>
>> BIF: realplay_gtk_atlas_restricted
>>
>>
>>
>> Branch:
>>
>> Atlas310
>>
>>
>>
>> Files Attached:
>>
>> diff.txt
>>
>>
>>
>> Thanks & Regards
>> Sushant Garg Index: hxplayer.cpp
>> ===================================================================
>> RCS file: /cvsroot/player/common/gtk/hxplayer.cpp,v
>> retrieving revision 1.60.2.2
>> diff -u -r1.60.2.2 hxplayer.cpp
>> --- hxplayer.cpp 2 Dec 2008 18:17:21 -0000 1.60.2.2
>> +++ hxplayer.cpp 3 Dec 2008 10:40:23 -0000
>> @@ -76,6 +76,9 @@
>> #include "HXClientCallbacks.h"
>> #include "HXClientConstants.h"
>> #include "HXClientCOMAccess.h"
>> +#include "pckunpck.h"
>> +#include "hxcomm.h"
>> +#include "hxprefs.h"
>>
>> #include "hx-i18n.h"
>>
>> @@ -1260,7 +1263,8 @@
>> // Initialize velocity control
>> HX_RESULT res;
>> IUnknown* pUnknown = NULL;
>> - + IHXPreferences* pPreferences = NULL;
>> + IHXBuffer* pBuffer = NULL;
>> if(ClientPlayerGetUnknown(player->helix_client_token, (void**)
>> &pUnknown))
>> {
>> res = pUnknown->QueryInterface(IID_IHXPlaybackVelocity,
>> @@ -1276,8 +1280,16 @@
>> res =
>> player->pPlaybackVelocity->InitVelocityControl(player->pPlaybackVelocityResponse);
>> } }
>> - }
>>
>> + res = pUnknown->QueryInterface(IID_IHXPreferences,
>> + (void**) &pPreferences);
>> + if(SUCCEEDED(res) && (HXR_OK == CreateAndSetBufferCCF(pBuffer,
>> (( Byte* ) "1"), 2, pUnknown)))
>> + {
>> + pPreferences->WritePref( "LiveSuperBuffer", pBuffer);
>> + }
>> + }
>> + HX_RELEASE(pBuffer); + HX_RELEASE(pPreferences);
>> ClientPlayerEnableSuperBuffer(player->helix_client_token, TRUE);
>> return player;
>> ------------------------------------------------------------------------
>>
>> _______________________________________________
>> Player-dev mailing list
>> Player-dev@helixcommunity.org
>> http://lists.helixcommunity.org/mailman/listinfo/player-dev
>>
_______________________________________________
Player-dev mailing list
Player-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/player-dev
--------------------------------------------------------------------------------
> _______________________________________________
> Player-dev mailing list
> Player-dev@helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/player-dev
>
_______________________________________________
Player-dev mailing list
Player-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/player-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic