'[Player-dev] CR: [#8338] Fixing can't edit or delete an Online'

[prev in list] [next in list] [prev in thread] [next in thread] 

List: helix-player-dev
Subject: [Player-dev] CR: [#8338] Fixing can't edit or delete an Online
From: Kinson Liu <kliu () real ! com>
Date: 2008-09-24 1:11:38
Message-ID: 48D993CA.5030404 () real ! com
[Download RAW message or body]

This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.

[Attachment #2 (multipart/alternative)]
This is a MIME-formatted message. If you see this text it means that your
E-mail software does not support MIME-formatted messages.


Modified by: kliu@real.com
Date: 9/23/2008
Project: RealPlayer for MID
Bug Number: 8338
Bug URL: https://bugs.helixcommunity.org/show_bug.cgi?id=8338

Synopsis: Fixing can't edit or delete an Online Music file if it was 
opened last time

Overview: When the player deletes, it checks against the pl.selected 
variable to see if the audio is currently playing back. However, what 
pl.selected actually means is the audio of that playlist lastly played 
back. When an audio A in Online Music is chosen to play back, 
pl.selected of Online Music is that audio A. Then the playlist is 
switched to All Songs and an audio B is chosen to play back; pl.selected 
of All Songs is B. Finally, the playlist is switched back to Online 
Music and audio A once again gets selected and is being deleted, the 
reported error occurs because pl.selected of Online Music is still 
holding A. Fix for this is to have the player check against 
self.cur_playlist.selected, which marks the realtime playback audio of 
all playlists, instead of pl.selected.

Files Added:
None

Files Modified:
player/mid/src/music_view.py

Image Size and Heap Use impact (Client -Only):
None

Platforms and Profiles Affected:
Platform: linux-2.2-libc6-gcc32-i586
Profile: Helix-client-moblin

Distribution Libraries Affected:
None

Distribution library impact and planned action:
None

Platforms and Profiles Build Verified:
Platform: linux-2.2-libc6-gcc32-i586
Profile: Helix-client-moblin

Platforms and Profiles Functionality verified:
Platform: linux-2.2-libc6-gcc32-i586
Profile: Helix-client-moblin

Branch: hxclient_3_4_1_atlas_restricted
 
Copyright assignment: I am a RealNetworks employee or contractor
-- 
------------------------------------------------------------------------
*Kinson Liu* | Software Development Engineer | RealNetworks, Inc. | 
kliu@real.com | 206.892.6177

[Attachment #5 (text/html)]

<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
</head>
<body bgcolor="#ffffff" text="#000000">
Modified by: <a class="moz-txt-link-abbreviated"
 href="mailto:kliu@real.com">kliu@real.com</a> 
Date: 9/23/2008 
Project: RealPlayer for MID 
Bug Number: 8338 
Bug URL: <a class="moz-txt-link-freetext"
 href="https://bugs.helixcommunity.org/show_bug.cgi?id=8076&amp;link=0">https://bugs.helixcommunity.org/show_bug.cgi?id=8338</a> 
 
Synopsis: Fixing can't edit or delete an Online Music file if it was
opened last time 
 
Overview: When the player deletes, it checks against the pl.selected
variable to see if the audio is currently playing back.&nbsp; However, what
pl.selected actually means is the audio of that playlist lastly played
back.&nbsp; When an audio A in Online Music is chosen to play back,
pl.selected of Online Music is that audio A.&nbsp; Then the playlist is
switched to All Songs and an audio B is chosen to play back;
pl.selected of All Songs is B.&nbsp; Finally, the playlist is switched back
to Online Music and audio A once again gets selected and is being
deleted, the reported error occurs because pl.selected of Online Music
is still holding A.&nbsp; Fix for this is to have the player check against
self.cur_playlist.selected, which marks the realtime playback audio of
all playlists, instead of pl.selected. 
 
Files Added: 
None 
 
Files Modified: 
player/mid/src/music_view.py 
 
Image Size and Heap Use impact (Client -Only): 
None 
 
Platforms and Profiles Affected: 
Platform: linux-2.2-libc6-gcc32-i586 
Profile: Helix-client-moblin 
 
Distribution Libraries Affected: 
None 
 
Distribution library impact and planned action: 
None 
 
Platforms and Profiles Build Verified: 
Platform: linux-2.2-libc6-gcc32-i586 
Profile: Helix-client-moblin 
 
Platforms and Profiles Functionality verified: 
Platform: linux-2.2-libc6-gcc32-i586 
Profile: Helix-client-moblin 
 
Branch: hxclient_3_4_1_atlas_restricted 
&nbsp; 
Copyright assignment: I am a RealNetworks employee or contractor
<div class="moz-signature">-- 
<hr>Kinson Liu | Software Development Engineer | RealNetworks,
Inc. | <a class="moz-txt-link-abbreviated" \
href="mailto:kliu@real.com">kliu@real.com</a> | 206.892.6177
</div>
</body>
</html>


["midplayer.diff" (text/plain)]

Index: music_view.py
===================================================================
RCS file: /cvsroot/player/mid/src/music_view.py,v
retrieving revision 1.7.4.2
diff -u -r1.7.4.2 music_view.py

--- music_view.py	5 Jun 2008 19:29:49 -0000	1.7.4.2
+++ music_view.py	24 Sep 2008 00:25:37 -0000
@@ -630,7 +630,7 @@
         songs = [model[path][COLUMN_URI] for path in path_list]
         titles = [model[path][COLUMN_TITLE] for path in path_list]
 
-        cur_item = pl.selected
+        cur_item = self.cur_playlist.selected
         if not cur_item:
             cur_song = None
         else:


_______________________________________________
Player-dev mailing list
Player-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/player-dev


[prev in list] [next in list] [prev in thread] [next in thread] 
