[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-player-dev
Subject:    RE: [Player-dev] CR: application spesific gui customisation
From:       "Eric Hyche" <ehyche () real ! com>
Date:       2008-05-12 20:27:16
Message-ID: 00e001c8b46e$92a1ab10$db68a8c0 () EHYCHED620
[Download RAW message or body]


Prajwal,

This seems to be the same diff that was reviewed
last week, and has already been checked in. Was this
just a burp by the helixcommunity email server, or
did you intend to send it again?

Also, I wanted to ask you: when do you think the
filling out of the default.gtkrc file will be finished?
(I'm just trying to get an idea when to tell the
devs on our side to switch to using the default.gtkrc
file...)

Eric

=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: player-dev-bounces@helixcommunity.org 
> [mailto:player-dev-bounces@helixcommunity.org] On Behalf Of 
> Prajwal Mohan
> Sent: Wednesday, May 07, 2008 6:17 PM
> To: player-dev@lists.helixcommunity.org
> Cc: midplayer-private-dev@lists.helixcommunity.org
> Subject: [Player-dev] CR: application spesific gui customisation
> 
> Description
> ----------------------------------
> Currently the mid player does not support application specific gui
> customization of GUI. The only way would be to change the 
> system wide gtkrc
> file. This patch will give that flexibility to mid player by 
> creating an
> application specific gtkrc file that can be loaded. 
> 
> <INSERT VERBOSE DESCRIPTION OF THE PROBLEM AND OF THE FIX>
> 
> Files Modified
> ----------------------------------
> player/mid/src/app.py
> player/mid/Makefile
> player/mid/installer/copyfiles.py
> 
> Files Added
> ----------------------------------
> Player/mid/default.gtkrc
> 
> Branches
> ---------------------------------
> HEAD
> 
> 
> Index: Makefile
> ===================================================================
> RCS file: /cvsroot/player/mid/Makefile,v
> retrieving revision 1.3
> diff -u -r1.3 Makefile
> --- Makefile	4 Mar 2008 19:56:37 -0000	1.3
> +++ Makefile	7 May 2008 22:05:17 -0000
> @@ -57,6 +57,8 @@
>  	@install -m 644 -D desktop/realplayer-music.desktop
> ${DESTDIR}/usr/share/applications/realplayer-music.desktop
>  	@install -m 644 -D desktop/realplayer-photo.desktop
> ${DESTDIR}/usr/share/applications/realplayer-photo.desktop
>  
> +	@install -m 644 -D default.gtkrc ${MEDIAAPPDIR}/default.gtkrc
> +
>  	@mkdir -p ${DESTDIR}/usr/share/icons/hicolor/32x32/apps/
>  	@install -m 644 -D icons/32x32/apps/*.png
> ${DESTDIR}/usr/share/icons/hicolor/32x32/apps/
>  
> Index: installer/copyfiles.py
> ===================================================================
> RCS file: /cvsroot/player/mid/installer/copyfiles.py,v
> retrieving revision 1.7
> diff -u -r1.7 copyfiles.py
> --- installer/copyfiles.py	5 May 2008 21:04:21 -0000	1.7
> +++ installer/copyfiles.py	7 May 2008 22:05:17 -0000
> @@ -402,6 +402,11 @@
>                      "realplayer.glade",
>                      "settings_dialog.glade",
>                      "dialogs.glade")
> +
> +# Copy default.gtkrc file
> +inst.CopyFile("../default.gtkrc",
> +              "usr/share/realplayer")
> +
>  # Create a special python file that contains the VERSION variable
>  f = open("version.py", "w")
>  f.write("VERSION='%s'\n" % (verstr))
> Index: src/app.py
> ===================================================================
> RCS file: /cvsroot/player/mid/src/app.py,v
> retrieving revision 1.8
> diff -u -r1.8 app.py
> --- src/app.py	3 Apr 2008 04:01:13 -0000	1.8
> +++ src/app.py	7 May 2008 22:05:17 -0000
> @@ -206,6 +206,15 @@
>          if self.options.uri != None:
>              self.cur_mode = utils.get_media_type(self.options.uri)
>          self.client = gconf.client_get_default()
> +
> +        #READ GTKRC
> +        skin_name = 
> self.client.get_string('/apps/realplayer/skin_name')
> +        if not skin_name:
> +            skin_name = 'default'
> +        gtkrc_filename = os.path.join(constant.MediaAppPath, 
> skin_name +
> '.gtkrc')
> +        if os.path.isfile(gtkrc_filename):
> +            gtk.rc_parse(gtkrc_filename)
> +
>          try:
>              theme =
> self.client.get_string("/desktop/gnome/interface/gtk_theme")
>              image_path = os.path.join('/usr/share/themes', 
> theme, 'images')
> 


_______________________________________________
Player-dev mailing list
Player-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/player-dev
[prev in list] [next in list] [prev in thread] [next in thread]