[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-player-dev
Subject:    [Player-dev] Re: Changes in the AboutBox dialog of MID player to
From:       Deepak Jain <deepakj () real ! com>
Date:       2008-05-09 17:55:09
Message-ID: 48248E90.2000200 () real ! com
[Download RAW message or body]

Hi Eric,

Yeah not necessary. Actually initially i when i accommodated one button 
for check for updates at the bottom of the dialog, to look
like in synchronous way, i called it button1 and for close button 
changed to 2 but after that i changed the ID of the Gtkbutton to
*button_for_updating* and forget to change it for close button. Surely 
will revert it back as it has no effect.

As far as *pass* on the handler, i did it because this 
*on_button_for_updating_handler* is a callback on the Check For Updates
button, and currently since its not working, so till the time it gets 
fixed, i just put their *pass* so that it didnt break the things.

Thanks,
Deepak Jain


Eric Hyche wrote:
> Deepak,
>
> Two questions:
>
> -	    <widget class="GtkButton" id="button1">
> +	    <widget class="GtkButton" id="button2">
>
> Why is it necessary to change the id of the OK/Close button?
> I didn't think we'd have to make any changes to that button.
>
> +	def on_button_for_updating_handler(self, data = None):
> +		pass
>
> What does "pass" do? Is that essentially like "return" in C?
>
> Rest looks good.
>
> Eric
>
> =============================================
> Eric Hyche (ehyche@real.com)
> Technical Lead
> RealNetworks, Inc.  
>
>   
>> -----Original Message-----
>> From: Deepak Jain [mailto:deepakj@real.com] 
>> Sent: Friday, May 09, 2008 1:41 AM
>> To: midplayer-private-dev; player-dev@helixcommunity.org
>> Cc: Eric Hyche
>> Subject: CR: Changes in the AboutBox dialog of MID player to 
>> give it a look like Windows Real Player 11
>>
>> Synopsis:
>> Changes in the AboutBox dialog of MID player to give it a look like 
>> Windows Real Player 11
>>  
>> Overview:
>> In the AboutBox dialog of MID player, we had to do changes so that it 
>> looks like Windows Real Player 11.
>> Earlier About Box has very basic information about the 
>> player, now many 
>> other information like Patent
>> information and Copyright information has been added in two 
>> Scrollable 
>> windows among other things.
>>
>> Also a check for updated button is added at the bottom of the dialog 
>> along with close button(Earlier it was OK
>> button). Check for updates button takes us to a web page for 
>> the updates 
>> related to player. *This button functionality
>> is yet to be implemented*
>> (Note:-- I am also attaching the screenshot for better 
>> understanding of 
>> the things)
>>
>> Files Added:
>> /player/mid/patents.txt
>> /player/mid/copyrights.txt
>>  
>> Files Modified:
>> /player/mid/glade/dialogs.glade
>> /player/installer/copyfiles.py
>> /player/src/top_menu.py
>>  
>> Image Size and Heap Use impact (Client -Only):
>> None.
>>  
>> Platforms and Profiles Affected:
>> None
>>  
>> Distribution Libraries Affected:
>> None
>>  
>> Distribution library impact and planned action:
>> None
>>  
>> Platforms and Profiles Build Verified:
>> BIF branch   -> hxclient_3_1_0_atlas
>> Target(s)      ->  player_mid_installer
>> Profile          ->  helix-client-all-defines
>> SYSTEM_ID -> linux-2.2-libc6-gcc32-i586
>>  
>> Branch:
>> hxclient_3_1_0_atlas, HEAD
>>  
>> Files Attached:
>> mid_diff.txt
>> copyrights.txt
>> patents.txt
>> AboutBox.png
>>
>> Thanks,
>> Deepak Jain
>>
>>     
>
>
>   


_______________________________________________
Player-dev mailing list
Player-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/player-dev
[prev in list] [next in list] [prev in thread] [next in thread]