[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-player-dev
Subject:    [Player-dev] CR-Client: Move Unified Logging GUIDs Definition to
From:       Daniel Yek <dyek () real ! com>
Date:       2007-12-17 6:13:56
Message-ID: 476613A4.8040600 () real ! com
[Download RAW message or body]

This is a MIME-formatted message.  If you see this text it means that your
E-mail software does not support MIME-formatted messages.


Modified by: dyek@real.com
Date: 12/16/2007
Project: Helix Player

Synopsis: Move Unified Logging GUIDs Definition to hxclientkit module

Overview: 
I found that I had to link against logging library in the player 
executable module, instead of hxclientkit library module.

However, GUIDs used in hxclientkit could have been defined in 
hxclientkit's GUID file, instead of the player GUID file.

So, this CR is to move Unified Logging GUIDs Definition from player
module into hxclientkit module. 

Halley needed the GUIDs definition to be checked into Atlas branch
as soon as possible. 
Thanks for pointing out the better fix.

I want to check if other teams using hxclientkit from 310Atlas and 
150Cay branch have already included the GUIDs definition in their 
TLC module and thus might break with duplicated definition if this 
change is checked in. Please take note. Thanks.



Files Modified:
player/app/gtk/guids.cpp - Remove from HEAD only.
player/hxclientkit/src/HXClientGuidIncludes.h - Add to 150Cay, 310Atlas, 
                                                and HEAD

Image Size and Heap Use impact (Client -Only):
None.

Platforms and Profiles Affected:
Linux

Distribution Libraries Affected:
None.

Distribution library impact and planned action:
None.

Platforms and Profiles Build Verified:
Profile: helix_client_all_define
Platform: Fedora Core 6

Platforms and Profiles Functionality verified:
Profile: helix_client_all_define
Platform: Fedora Core 6

Branch: 
150Cay, 310Atlas, HEAD

Copyright assignment: I am a RealNetworks employee.

-- 
Daniel Yek.


["hxclientkit_atlas[1].diff" (text/plain)]

Index: HXClientGuidIncludes.h
===================================================================
RCS file: /cvsroot/player/hxclientkit/src/HXClientGuidIncludes.h,v
retrieving revision 1.8.2.1
diff -u -w -r1.8.2.1 HXClientGuidIncludes.h
--- HXClientGuidIncludes.h	8 Nov 2007 07:57:57 -0000	1.8.2.1
+++ HXClientGuidIncludes.h	17 Dec 2007 05:38:30 -0000
@@ -89,3 +89,8 @@
 #include "hxengin.h"
 #include "hxplayvelocity.h"
 
+#include "ihxtlogsystem.h"
+#include "ihxtlogsystemcontext.h"
+#include "ihxtlogcontextobserver.h"
+#include "hxdllaccess.h"
+

["moveGuidsToHxclientkit[1].diff" (text/plain)]

Index: player/hxclientkit/src/HXClientGuidIncludes.h
===================================================================
RCS file: /cvsroot/player/hxclientkit/src/HXClientGuidIncludes.h,v
retrieving revision 1.5.2.3
diff -u -w -r1.5.2.3 HXClientGuidIncludes.h
--- player/hxclientkit/src/HXClientGuidIncludes.h	21 Oct 2005 18:39:27 -0000	1.5.2.3
+++ player/hxclientkit/src/HXClientGuidIncludes.h	17 Dec 2007 05:40:36 -0000
@@ -85,3 +85,10 @@
 
 #include "hxengin.h"
 
+#include "ihxtlogsystem.h"
+#include "ihxtlogsystemcontext.h"
+#include "ihxtlogcontextobserver.h"
+#include "hxdllaccess.h"
+
+
+
Index: player/app/gtk/guids.cpp
===================================================================
RCS file: /cvsroot/player/app/gtk/guids.cpp,v
retrieving revision 1.15
diff -u -w -r1.15 guids.cpp
--- player/app/gtk/guids.cpp	10 Dec 2007 23:03:08 -0000	1.15
+++ player/app/gtk/guids.cpp	17 Dec 2007 05:47:14 -0000
@@ -1,5 +1,5 @@
 /* ***** BEGIN LICENSE BLOCK *****
- * Source last modified: $Id: guids.cpp,v 1.15 2007/12/10 23:03:08 dyek Exp $
+ * Source last modified: $Id: guids.cpp,v 1.14 2007/07/06 20:49:18 jfinnecy Exp $
  * 
  * Portions Copyright (c) 1995-2004 RealNetworks, Inc. All Rights Reserved.
  * 
@@ -74,11 +74,6 @@
 #include "hxdtdr.h"
 #include "hxtbuf.h"
 
-#include "ihxtlogsystem.h"
-#include "ihxtlogsystemcontext.h"
-#include "ihxtlogcontextobserver.h"
-#include "hxdllaccess.h"
-
 // From common/include/hxsrcin.h (which includes ihxpckts.h, and thus cannot be \
included here directly)  DEFINE_GUID(IID_IHXSourceInput, 0xebf8d220, 0x40f7, 0x11d6, \
0xab, 0x3f, 0x0, 0x1, 0x2, 0x51, 0xb3, 0x40);  



_______________________________________________
Player-dev mailing list
Player-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/player-dev


[prev in list] [next in list] [prev in thread] [next in thread]