[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-player-dev
Subject:    [Player-dev] CR/CN-Client: Fixed HXStatusDisplay leaks.
From:       Daniel Yek <dyek () real ! com>
Date:       2007-04-23 22:41:24
Message-ID: 6.2.1.2.2.20070423153940.0b2c2070 () mailone ! real ! com
[Download RAW message or body]

Modified by: dyek@real.com
Date: 4/22/2007
Project: Helix Player

Synopsis: Fixed HXStatusDisplay leaks.

Overview:
   Two assignment was made to window->status_bar causing the first
   HXStatusDisplay container to be leaked.
   This change fixed the leak of the first
   hxstatus_display_top_new() return value.
   With this fix, the HXStatusDisplay widgets are destroyed properly
   during player shutdown.

Files Modified:
   player/app/gtk/mainapp.cpp

Image Size and Heap Use impact (Client -Only):
None.

Platforms and Profiles Affected:
Linux

Distribution Libraries Affected:
None.

Distribution library impact and planned action:
None.

Platforms and Profiles Build Verified:
Profile: helix_client_all_define
Platform: Fedora Core 5

Platforms and Profiles Functionality verified:
Profile: helix_client_all_define
Platform: Fedora Core 5

Branch: HEAD

Copyright assignment: I am a RealNetworks employee.


Index: mainapp.cpp
===================================================================
RCS file: /cvsroot/player/app/gtk/mainapp.cpp,v
retrieving revision 1.132
diff -u -w -r1.132 mainapp.cpp
--- mainapp.cpp 29 Mar 2007 18:56:18 -0000      1.132
+++ mainapp.cpp 22 Apr 2007 07:48:09 -0000
@@ -5088,10 +5088,6 @@

      glade_xml_signal_autoconnect(window->xml);

-    window->status_bar = hxstatus_display_top_new();
-
-    g_return_val_if_fail(window->status_bar != NULL, FALSE);
-
      if(!get_widgets(window))
      {
         return FALSE;



-- 
Daniel Yek


_______________________________________________
Player-dev mailing list
Player-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/player-dev
[prev in list] [next in list] [prev in thread] [next in thread]