[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-filesystem-dev
Subject:    [Filesystem-dev] Re: [Android-port-dev] CR: Changes to fix a crash
From:       Jamie Gordon <jgordon () real ! com>
Date:       2010-10-28 16:32:09
Message-ID: 4CC9A589.5070905 () real ! com
[Download RAW message or body]

ok

On 10/28/2010 12:45 AM, Caijun Song wrote:
> Synopsis: Changes to fix a crash issue when generate thumbnail for mkv file
>
> Overview: Helix will crash when generate thumbnail for mkv file, this is
> because mkv file format use CSimpleFileObject::InitSync during
> InitFileFormat. InitSync will set m_pDataFile to NULL if file access mode
> changed, which is wrong because we have a logic like HX_ASSERT(m_pDataFile)
> after that. This is not a problem in normal playback case because file
> access mode won't change when this function get called. This change avoids
> setting m_pDataFile to NULL in InitSync just like CSimpleFileObject::Init
> does.
>
>
> Files Added:
> None
>
> Files Modified:
> filesystem/local/full/smplfsys.cpp
>
> Platforms and Profiles Functionality verified:
> System: android-2.2-arm-qsd_8650a
> Profile: helix-client-android-full
> Target: android_omx
> Branch: hxclient_3_6_2_atlas
>
> Branch Affected:
> hxclient_3_1_0_atlas hxclient_3_6_1_atlas hxclient_3_6_2_atlas
>
> Copyright assignment: I am a RealNetworks employee
>
>
> Regards.
> Caijun

_______________________________________________
Filesystem-dev mailing list
Filesystem-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/filesystem-dev
[prev in list] [next in list] [prev in thread] [next in thread]