[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-filesystem-dev
Subject:    [Filesystem-dev] RE: [Nokia-private-dev] CR: PWAG-7QY3Q7:
From:       <ext-jose-antonio.2.zamora () nokia ! com>
Date:       2009-05-29 17:13:24
Message-ID: B26CC1CBE7B84E4DAC8886E1C12FB38001184D8C () xesebe102 ! nee ! nokia ! com
[Download RAW message or body]

Hi Greg,
 
          as you mention the problem is a memory leak caused by buffers that have not \
been released.   
Br,
Jose

________________________________

From: ext Gregory Wright [mailto:gwright@real.com]
Sent: Fri 5/29/2009 5:19 PM
To: Zamora Jose-Antonio.2 (EXT-Dextra-MSW/Mexico)
Cc: filesystem-dev@helixcommunity.org; nokia-private-dev@helixcommunity.org
Subject: Re: [Nokia-private-dev] CR: PWAG-7QY3Q7: [Helix_Test_Util] Helix crashes \
when closing the playback of shoutcast internet radio stations



What is the crash exactly? Just the system running out of memory? 
Usually,
not releasing a buffer just causes leaks.

But, the diff looks good.
--greg.


On May 27, 2009, at 3:05 PM, ext-jose-antonio.2.zamora@nokia.com wrote:

> "Nokia submits this code under the terms of a commercial 
> contribution agreement with RealNetworks, and I am authorized to 
> contribute this code under said agreement."
> 
> Modified by:  ext-jose-antonio.2.zamora@nokia.com
> 
> Reviewed by:
> 
> TSW Id: PWAG-7QY3Q7
> 
> Date: 27/05/2009
> 
> Project: SymbianMmf_rel
> 
> Synopsis: [Helix_Test_Util] Helix crashes when closing the playback 
> of shoutcast internet radio stations
> 
> Overview:
> Inside CHTTPFileObject::_DoSomeReadingFromSocket method, pReadBuffer 
> is initialized and added to m_PreprocessedReadBuffers list which 
> should be released after being processed, but when the user switches 
> from radio station A to radio station B and viceversa, there are 
> sometimes preprocessed buffers left in the m_PreprocessedReadBuffers 
> list that are not getting released, and this will cause the system 
> to crash.
> 
> Fix:
> To avoid that we need to release those preprocessed buffers when 
> CHTTPFileObject::Close() gets called.
> 
> Files modified & changes:
> \filesystem\http\httpfsys.cpp
> 
> Image Size and Heap Use impact: None
> 
> Module Release testing (STIF, Audio) : Passed
> 
> Test case(s) Added  : No
> 
> Memory leak check performed : Passed, No leaks found
> 
> Platforms and Profiles Build Verified: helix-client-s60-50-mmf-mdf-arm
> helix-client-
> s60-32-mmf-mdf-arm
> 
> Platforms and Profiles Functionality verified: armv5
> 
> Branch: 221Cays, 223Cays, 210Cays, HEAD
> <filesystem.diff>_______________________________________________
> Nokia-private-dev mailing list
> Nokia-private-dev@helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/nokia-private-dev




_______________________________________________
Filesystem-dev mailing list
Filesystem-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/filesystem-dev


[prev in list] [next in list] [prev in thread] [next in thread]