[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-filesystem-dev
Subject:    RE: [Filesystem-dev] CR: Can't play RA clip due to
From:       "Eric Hyche" <ehyche () real ! com>
Date:       2008-04-04 12:50:05
Message-ID: 009701c89652$68c191a0$db68a8c0 () EHYCHED620
[Download RAW message or body]


Looks good.

=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: filesystem-dev-bounces@helixcommunity.org 
> [mailto:filesystem-dev-bounces@helixcommunity.org] On Behalf 
> Of Ashish.As.Gupta@nokia.com
> Sent: Thursday, April 03, 2008 10:32 AM
> To: filesystem-dev@helixcommunity.org
> Subject: [Filesystem-dev] CR: Can't play RA clip due to 
> missinginitialization for m_pPendingReadBufAsyn
> 
> Can't play RA clip due to missing initialization for
> m_pPendingReadBufAsync
> 
> Nokia submits this code under the terms of a commercial contribution
> agreement with RealNetworks, and I am authorized to 
> contribute this code
> under said agreement."
> 
> Modified by:  ashish.as.gupta@nokia.com
> 
> Reviewed by: 
> 
> Date: 02-Apr-2008
> 
> Project: SymbianMmf_wm
> 
> TSW-Id: SXUU-7D5NGH
> 
> Synopsis: 
> 
> m_pPendingReadBufAsync was not initialized with NULL.
> CHXMiniFileObject::Seek checked for m_pPendingReadBufAsync not being
> NULL and called ReadDone(HXR_CANCELLED, NULL). This resulted in error.
> Fix is to initialize the variable in the constructor.
> 
> Files Modified:
> 
> filesystem/local/mini/minifileobj.cpp
> 
> Image Size and Heap Use impact: none
> 
> Module Release testing (STIF): Yes.
> 
> Test case(s) Added: none
> 
> Memory leak check performed: Yes, no new leaks introduced.
> 
> Platforms and Profiles Build Verified: 
>     armv5 / helix-client-s60-50-mmf-mdf-arm
>     winscw / helix-client-s60-50-mmf-mdf-arm
> 
> Platforms and Profiles Functionality verified: 
>     armv5 / helix-client-s60-50-mmf-mdf-arm
>     winscw / helix-client-s60-50-mmf-mdf-arm
> 
> Branch: 
>     HEAD, hxclient_2_1_0_cayennes
> 
> 
> 
> Index: minifileobj.cpp
> ===================================================================
> RCS file: /cvsroot/filesystem/local/mini/minifileobj.cpp,v
> retrieving revision 1.23.2.9
> diff -u -w -r1.23.2.9 minifileobj.cpp
> --- minifileobj.cpp	14 Mar 2008 18:25:12 -0000	1.23.2.9
> +++ minifileobj.cpp	2 Apr 2008 21:32:55 -0000
> @@ -112,6 +112,7 @@
>  #if defined(HELIX_FEATURE_MMF_DATASOURCE)
>        ,m_pDataSource         (NULL)
>        ,m_bAsyncReadSupported (FALSE)
> +      ,m_pPendingReadBufAsync (NULL)
>  #endif
>  {
>      DPRINTF(D_MINI_FO, ("CHXMiniFO::CHXMiniFileObject()\n"));
> 
> _______________________________________________
> Filesystem-dev mailing list
> Filesystem-dev@helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/filesystem-dev
> 


_______________________________________________
Filesystem-dev mailing list
Filesystem-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/filesystem-dev
[prev in list] [next in list] [prev in thread] [next in thread]