[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-filesystem-dev
Subject:    [Filesystem-dev] Re: CN-Client: Bug 157327[Player crashes when
From:       Anil Jaiswal <ajaiswal () real ! com>
Date:       2006-01-10 18:06:41
Message-ID: 6.2.1.2.2.20060110095241.02ea9600 () mailone ! real ! com
[Download RAW message or body]

Greg,
I made a mistake below and said 120Cays.
The changes had  been into checked hxclient_2_1_0_cayennes.
Sorry for my mistake.
~Anil

At 08:12 PM 1/9/2006, Greg Wright wrote:
>Anil Jaiswal wrote:
>>Thanks Greg for CR. This is now checked into Head,150Cay and 120Cays
>
>That should be 210CayS (hxclient_2_1_0_cayennes)
>
>--greg.
>
>
>>branches.
>>
>>Modified by: ajaiswal@real.com
>>Reviewed by: gwright@real.com
>>Date: 01-09-2006
>>Project: HEAD, Cay150
>>Thanks and regards,
>>~Anil Jaiswal
>>At 04:34 PM 1/9/2006, Greg Wright wrote:
>>>I think this fix is fine. However, pay special attention to the
>>>files on HEAD, they appear different. On 150Cay we have:
>>>
>>>    m_pChunkedEncoding->buf = new char[DEFAULT_CHUNK_SIZE];
>>>    pChunkedEncoding->buf = new char[pChunkedEncoding->buf_size];
>>>
>>>but on HEAD we have:
>>>
>>>   m_pChunkedEncoding->buf = new char[DEFAULT_CHUNK_SIZE];
>>>   pChunkedEncoding->buf = new char[DEFAULT_TCP_READ_SIZE + 1];
>>>   pChunkedEncoding->buf = new char[pChunkedEncoding->size + 1];
>>>   pChunkedEncoding->buf = new char[pChunkedEncoding->buf_size];
>>>
>>>The problem you found comes from a difference of the size allocated
>>>and the size we are memset'ing. Make sure all the places on the
>>>HEAD are good as well since there are more then 1.
>>>
>>>Also, please commit this change to:
>>>
>>>
>>>  HEAD, 150Cay and 210CayS
>>>
>>>
>>>Don't forget to follow the new CR process and cut and paste the
>>>original CR text (no diffs) into the cvs commit comments.
>>>
>>>--greg.
>>>
>>>
>>>
>>>
>>>
>>>Anil Jaiswal wrote:
>>>>Modified by: ajaiswal@real.com
>>>>Date: 01-09-2006
>>>>Project: HEAD, Cay150
>>>>Bug Number:157327 [Player crashes when switching between pick 5 SP 
>>>>content ]
>>>>Synopsis:
>>>>The current change is to fix player crash occurring while switching 
>>>>between video
>>>>clips of SuperPass pick five section.
>>>>Overview:
>>>>Debugged and traced through the source and narrowed the crash to 
>>>>httpfsys.dll. It's
>>>>observed that player crashes in 
>>>>CHTTPFileObject::DecodeChunkedEncoding() while
>>>>HX_VECTOR_DELETE(pChunkedEncoding->buf) during the parsing of chunk body.
>>>>It looks to me that memset() of buffer after allocating 
>>>>pChunkedEncoding->buf is
>>>>responsible for the crash where it uses wrong pChunkedEncoding->buf_size+1
>>>>instead of pChunkedEncoding->buf_size. Because of this, player was crashing
>>>>while freeing up the memory via HX_VECTOR_DELETE(pChunkedEncoding->buf).
>>>>Files Added:
>>>>None.
>>>>Files Modified:
>>>>RCS file: /cvsroot/filesystem/http/httpfsys.cpp
>>>>Image Size and Heap Use impact (Client -Only):
>>>>None.
>>>>Platforms and Profiles Affected:
>>>>All.
>>>>Distribution Libraries Affected:
>>>>None
>>>>Distribution library impact and planned action:
>>>>None
>>>>Platforms and Profiles Build Verified:
>>>>Windows platform,  helix-client-all-defines
>>>>Platforms and Profiles Functionality verified:
>>>>Functionality verified on Windows platform
>>>>Profile: helix-client-all-defines
>>>>Branch: HEAD, Cay150
>>>>CVS diff:
>>>>cvs diff: Diffing .
>>>>Index: httpfsys.cpp
>>>>===================================================================
>>>>RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
>>>>retrieving revision 1.88
>>>>diff -u -w -r1.88 httpfsys.cpp
>>>>--- httpfsys.cpp        11 Oct 2005 22:22:05 -0000      1.88
>>>>+++ httpfsys.cpp        10 Jan 2006 00:09:10 -0000
>>>>@@ -8862,7 +8862,7 @@
>>>>                          if( pChunkedEncoding->buf )
>>>>                          {
>>>>-                            memset(pChunkedEncoding->buf, 0, 
>>>>pChunkedEncoding->buf_size + 1);
>>>>+                            memset(pChunkedEncoding->buf, 0, 
>>>>pChunkedEncoding->buf_size);
>>>>                              pChunkedEncoding->read = 0;
>>>>                              pChunkedEncoding->state = CE_BODY_PENDING;
>>>>                          }
>>>>cvs diff: Diffing platform
>>>>cvs diff: Diffing platform/mac
>>>>cvs diff: Diffing platform/openwave
>>>>cvs diff: Diffing platform/unix
>>>>cvs diff: Diffing platform/win
>>>>cvs diff: Diffing pub
>>>>QA Instructions:
>>>>Regress PR 157327
>>>>
>>>>_______________________________________________
>>>>Filesystem-dev mailing list
>>>>Filesystem-dev@helixcommunity.org
>>>>http://lists.helixcommunity.org/mailman/listinfo/filesystem-dev
>>Copyright assignment:
>>In consideration for RealNetworks' hosting and maintenance
>>of my modification, I agree to assign to RealNetworks full
>>copyright ownership of the code included in the attached
>>patch, and agree that RealNetworks has no duty of accounting
>>to me for it. I warrant that this code is entirely original
>>to and owned by me, that I can legally grant the copyright
>>assignment, and that my contribution does not violate any other
>>person's rights, and laws or breach any contract. I understand
>>that RealNetworks may license this code under RPSL, RCSL,
>>and/or any other license at RealNetworks' discretion, and use
>>the code in any way.



[prev in list] [next in list] [prev in thread] [next in thread]