[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-filesystem-cvs
Subject:    [Filesystem-cvs] http httpfsys.cpp,1.60,1.61
From:       bobclark () helixcommunity ! org
Date:       2004-11-17 20:42:38
[Download RAW message or body]

Update of /cvsroot/filesystem/http
In directory cvs-new:/tmp/cvs-serv11262

Modified Files:
	httpfsys.cpp 
Log Message:
avoid risky EnsureEscapedURL call on fragment of an url; unneeded anyway since CHXURL \
now internally takes care of escaping. fixes bug 127641. Thanks for the CR LiamM.

Index: httpfsys.cpp
===================================================================
RCS file: /cvsroot/filesystem/http/httpfsys.cpp,v
retrieving revision 1.60
retrieving revision 1.61
diff -u -d -r1.60 -r1.61
--- httpfsys.cpp	17 Nov 2004 19:13:03 -0000	1.60
+++ httpfsys.cpp	17 Nov 2004 20:42:36 -0000	1.61
@@ -2341,6 +2341,7 @@
                 pUrlBuffer)
             {
                 pURL = ::new_string((const char*)pUrlBuffer->GetBuffer());
+                HXLOGL2(HXLOG_HTTP, "_OpenFile properly escaped URL is %s", \
NULLOK(pURL));  HX_RELEASE(pUrlBuffer);
             }
             HX_RELEASE(pHeader);
@@ -2352,6 +2353,7 @@
     // we fall back to the original URL.
     if (!pURL)
     {
+        HXLOGL1(HXLOG_HTTP, "_OpenFile url had trouble parsing! Fallback to original \
URL");  pURL = ::new_string(pTempURL);
     }
 
@@ -2411,12 +2413,7 @@
 
     if (pTemp)
     {
-        // Fix for PR104465
-        // CHXURL now always unescapes the URL which means we need to make sure that \
                resource is correctly encoded
-        // before sending to the server.
-
         m_strResource = pTemp;
-        HXEscapeUtil::EnsureEscapedURL(m_strResource); 
         *pTemp = '\0';
     }
 


[prev in list] [next in list] [prev in thread] [next in thread]