[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-datatype-dev
Subject:    [datatype-dev] RE: [Nokia-private-dev] CR: IWOD-83KC2Y: Audio
From:       <ext-anugrah.2.kashari () nokia ! com>
Date:       2010-03-30 5:53:07
Message-ID: F5530C438DC47349A7BFA40DC96D95EA2AA7EEAE08 () NOK-EUMSG-02 ! mgdnok ! nokia ! com
[Download RAW message or body]

Thanks Greg, 
Checked in 210Cays , Brizo420 and Head

-----Original Message-----
From: ext Gregory Wright [mailto:gwright@real.com] 
Sent: Monday, March 29, 2010 11:01 PM
To: Kashari Anugrah.2 (EXT-Sasken/Bangalore)
Cc: datatype-dev@helixcommunity.org; nokia-private-dev@helixcommunity.org
Subject: Re: [Nokia-private-dev] CR: IWOD-83KC2Y: Audio Related Panic When Playing \
WMVHD Clip With 6 Channel Audio

Looks good.
--greg.


On Mar 28, 2010, at 8:57 PM, <ext-anugrah.2.kashari@nokia.com> \
<ext-anugrah.2.kashari@nokia.com> wrote:

> "Nokia submits this code under the terms of a commercial contribution agreement \
> with RealNetworks, and I am authorized to contribute this code under said \
> agreement" 
> Modified By: ext-anugrah.2.kashari@nokia.com
> 
> Review By: Rathinasamy Rajesh
> 
> TSW-ID:  IWOD-83KC2Y
> 
> Date : 29/03/2010
> 
> Project: SymbianMmf_wm
> 
> Synopsis:  Audio Related Panic When Playing WMVHD Clip With 6 Channel Audio
> 
> Overview:  Audio stream in this file has 6 channel. This is not supported but this \
> was not checked while initializing devsound. As a result devsound configuration \
> fails and this leads to various problem including crash when setting volume. 
> Fix:  Added code to check maximum number of channel supported(in class \
> HXMDFAudioWMA). 
> Files modified & changes 210Cays , Brizo420 and Head :
> /cvsroot/datatype/mdf/audio/dsp/mdfaudfmt.cpp
> /cvsroot/datatype/mdf/audio/dsp/mdfaudfmt.h
> 
> Image Size and Heap Use impact: No major impact
> 
> Module Release testing (STIF) :  Ongoing
> 
> Test case(s) Added : No
> 
> Memory leak check performed : Passed, No additional leaks introduced.
> 
> Platforms and Profiles Build Verified: helix-client-s60-52-mmf-mdf-dsp              \
>  
> Platforms and Profiles Functionality verified: armv5
> 
> Branch : 210Cays, Brizo420 & Head :
> 
> Index: mdfaudfmt.cpp
> ===================================================================
> RCS file: /cvsroot/datatype/mdf/audio/dsp/mdfaudfmt.cpp,v
> retrieving revision 1.1.2.17
> diff -u -w -r1.1.2.17 mdfaudfmt.cpp
> --- mdfaudfmt.cpp       26 Jan 2010 17:52:31 -0000      1.1.2.17
> +++ mdfaudfmt.cpp       29 Mar 2010 03:54:10 -0000
> @@ -57,6 +57,7 @@
> #include "mdfdebug.h"
> #include "mdfaudfmt.h"
> #include "stdlib.h"
> +#include "hxprefutil.h"
> 
> //Dolby Digital frame size table, the first column is framesizecode, it is the \
> lower 6 bits // of the 4th byte, the 2nd column is the norminal bit rate, the 3rd, \
> 4th and 5th columns are @@ -660,10 +661,14 @@
> HXMDFAudioWMA::HXMDFAudioWMA(IUnknown *pContext)
> {
> m_tFourCC = KMMFFourCCCodeWMA;
> +    // save the context for collecting information
> +    m_pContext = pContext;
> +    HX_ADDREF(m_pContext);   
> }
> 
> HXMDFAudioWMA::~HXMDFAudioWMA()
> {
> +    HX_RELEASE(m_pContext);
> }
> 
> 
> @@ -730,6 +735,14 @@
> }
> free(buf);
> 
> +    UINT16 usWMAChannels = 2;
> +    ReadPrefUINT16(m_pContext, "MAXSupportedWMAChannels", usWMAChannels);
> +    if(m_uChannels > usWMAChannels)
> +    {
> +        HXLOGL2(HXLOG_WMAR, "HXMDFAudioWMA::ParseConfig Error:More than %d \
> channels not supported. Channels for this Stream:%d", usWMAChannels, m_uChannels ); \
> +        result = HXR_UNSUPPORTED_AUDIO; +    }
> +
> return result;
> }
> 
> Index: mdfaudfmt.h
> ===================================================================
> RCS file: /cvsroot/datatype/mdf/audio/dsp/mdfaudfmt.h,v
> retrieving revision 1.1.2.11
> diff -u -w -r1.1.2.11 mdfaudfmt.h
> --- mdfaudfmt.h 15 Dec 2009 20:37:34 -0000      1.1.2.11
> +++ mdfaudfmt.h 29 Mar 2010 03:54:20 -0000
> @@ -183,6 +183,8 @@
> 
> UINT32 m_MDFWMAHeader[WMAMMFCODEC10_HEADER_SIZE/sizeof(UINT32)];
> 
> +        IUnknown*                   m_pContext;
> +
> };     
> 
> class HXMDFAudioAC3 : public HXMDFAudioFormat
> 
> 
> <ATT00001..txt>


_______________________________________________
Datatype-dev mailing list
Datatype-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-dev


[prev in list] [next in list] [prev in thread] [next in thread]