[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-datatype-dev
Subject:    Re: [datatype-dev] CN: RealText -- (re)initialize	uninitialized
From:       Tony Seaward <tseaward () real ! com>
Date:       2010-02-18 3:19:57
Message-ID: 4B7CB1DD.6090809 () real ! com
[Download RAW message or body]

Fair enough, thanks for the input.

Tony Seaward
Helix DNA Program Manager
RealNetworks, Inc.
(206) 674-2391


On 2/17/10 3:48 PM, Robert Clark wrote:
> Heh, I originally only messed it up on 150Cay so that's the only place  
> that needed fixing.
>
> --Bob
>
> On Feb 17, 2010, at 3:24 PM, Tony Seaward wrote:
>
>   
>> Bob-
>> Is this useful for any other branches besides 150Cay?
>>
>> Tony Seaward
>> Helix DNA Program Manager
>> RealNetworks, Inc.
>> (206) 674-2391
>>
>>
>> On 2/17/10 2:27 PM, Robert Clark wrote:
>>     
>>> Thanks Greg, you sweet-talker. :-) Committed to 150Cay.
>>>
>>> --Bob
>>>
>>> On Feb 17, 2010, at 1:28 PM, Gregory Wright wrote:
>>>
>>>
>>>       
>>>> Looks good, almost iPad good. :)
>>>>
>>>> --greg.
>>>>
>>>>
>>>> On Feb 17, 2010, at 1:14 PM, Bob Clark wrote:
>>>>
>>>>
>>>>         
>>>>> Synopsis/Overview:
>>>>>
>>>>> I did an "oopsie" a year ago in this change:
>>>>>
>>>>> http://lists.helixcommunity.org/pipermail/datatype-dev/2009-January/007302.html
>>>>>
>>>>> In txtwindw.cpp, I accidentally removed the initialization of
>>>>> m_pOffscreenWorld and later cleanup. I should have left in that
>>>>> initialization if we're building in 32-bit mode. This change fixes
>>>>> this correctly.
>>>>>
>>>>> Files Changed:
>>>>>
>>>>> datatype/text/realtext/common/txtwindw.cpp
>>>>>
>>>>> Image Size and Heap Use Impact: Negligible
>>>>>
>>>>> Platform and Profiles Build Verified:
>>>>>
>>>>> Branches: 150Cay
>>>>>
>>>>> --Bob
>>>>>
>>>>>
>>>>> Index: txtwindw.cpp
>>>>> ===================================================================
>>>>> RCS file: /cvsroot/datatype/text/realtext/common/txtwindw.cpp,v
>>>>> retrieving revision 1.3.6.1
>>>>> diff -u -w -r1.3.6.1 txtwindw.cpp
>>>>> --- txtwindw.cpp	8 Jan 2009 04:34:01 -0000	1.3.6.1
>>>>> +++ txtwindw.cpp	17 Feb 2010 21:12:24 -0000
>>>>> @@ -318,6 +318,8 @@
>>>>> 	, m_LPBITMAPINFO(NULL)
>>>>> 	, m_pBits(NULL)
>>>>> #endif
>>>>> +#elif defined(_MAC_UNIX) && !__LP64__
>>>>> +, m_pOffScreenWorld(NULL)
>>>>> #endif
>>>>> 	, m_visibleWindowWidth(0L)
>>>>> 	, m_visibleWindowHeight(0L)
>>>>> @@ -392,6 +394,12 @@
>>>>>    {
>>>>> 	DeleteDC((HDC)m_pDeviceContextMemory);
>>>>>    }
>>>>> +#elif defined(_MAC_UNIX) && !__LP64__
>>>>> +    if(m_pOffScreenWorld)
>>>>> +    {
>>>>> +        DisposeGWorld(m_pOffScreenWorld);
>>>>> +        m_pOffScreenWorld=NULL;
>>>>> +    }
>>>>> #else
>>>>>    //platform-specific code needed here.
>>>>> #endif
>>>>>
>>>>>
>>>>> -- 
>>>>> Bob Clark
>>>>> Lead Software Development Engineer
>>>>> RealPlayer for Mac OS X
>>>>> RealNetworks, Inc.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> _______________________________________________
>>>>> Datatype-dev mailing list
>>>>> Datatype-dev@helixcommunity.org
>>>>> http://lists.helixcommunity.org/mailman/listinfo/datatype-dev
>>>>>
>>>>>           
>>>>         
>>>       
>> _______________________________________________
>> Datatype-dev mailing list
>> Datatype-dev@helixcommunity.org
>> http://lists.helixcommunity.org/mailman/listinfo/datatype-dev
>>     
>   

_______________________________________________
Datatype-dev mailing list
Datatype-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-dev
[prev in list] [next in list] [prev in thread] [next in thread]