[prev in list] [next in list] [prev in thread] [next in thread]
List: helix-datatype-dev
Subject: [datatype-dev] CR needed: CPHU-7YMRTM,
From: <Yury.Ramanovich () nokia ! com>
Date: 2009-12-16 21:42:04
Message-ID: BE808F92D8B85A4FB9A6D26B46CB39EC2905B295AC () NOK-EUMSG-03 ! mgdnok ! nokia ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
"Nokia submits this code under the terms of a commercial contribution agree=
ment with RealNetworks, and I am authorized to contribute this code under s=
aid agreement."
Modified by: yury.ramanovich@nokia.com<mailto:yury.ramanovich@nokia.com>, =
dushyant.vipradas@nokia.com<mailto:dushyant.vipradas@nokia.com>
Reviewed by:
Date: 12/16/2009
Project: SymbianMmf_wm
ErrorId: CPHU-7YMRTM, ou1cimx1#218155
Synopsis: crash during AVI file playback
Overview: AVI stream index was not set (NULL) for AVI v1.0 files, which lea=
d to crash during CAVIIndex::GetMaxChunkSize()
Solution: set AVI stream index for all AVI v1.0 files
Files Added:
None.
Files Modified:
datatype/avi/fileformat/aviffpln.cpp
Image Size and Heap Use impact: minor
Module Release testing (STIF) : MRT subset
Test case(s) Added : No.
Memory leak check performed : Yes. No new leaks introduced
Platforms and Profiles Build Verified: helix-client-s60-50-mmf-mdf-dsp
helix-client-s60-52-mmf-mdf-dsp
Platforms and Profiles Functionality verified: armv5, winscw
Branch: cay210, brizo420, HEAD
[Attachment #5 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from rtf -->
<style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 \
2px solid; } --></style> </head>
<body>
<font face="Courier New, monospace" size="2">
<div>"Nokia submits this code under the terms of a commercial contribution \
agreement with RealNetworks, and I am authorized to contribute this code under said \
agreement."</div> <div> </div>
<div>Modified by: <a href="mailto:yury.ramanovich@nokia.com"><font \
color="#0000FF"><u>yury.ramanovich@nokia.com</u></font></a>, <a \
href="mailto:dushyant.vipradas@nokia.com"><font \
color="#0000FF"><u>dushyant.vipradas@nokia.com</u></font></a></div> <div> </div>
<div>Reviewed by: </div>
<div> </div>
<div>Date: 12/16/2009</div>
<div> </div>
<div>Project: SymbianMmf_wm </div>
<div> </div>
<div>ErrorId: CPHU-7YMRTM, ou1cimx1#218155</div>
<div> </div>
<div>Synopsis: crash during AVI file playback</div>
<div> </div>
<div>Overview: AVI stream index was not set (NULL) for AVI v1.0 files, which lead to \
crash during CAVIIndex::GetMaxChunkSize()</div> <div> </div>
<div>Solution: set AVI stream index for all AVI v1.0 files</div>
<div> </div>
<div> </div>
<div>Files Added: </div>
<div>None.</div>
<div> </div>
<div>Files Modified:</div>
<div>datatype/avi/fileformat/aviffpln.cpp</div>
<div> </div>
<div> </div>
<div>Image Size and Heap Use impact: minor</div>
<div> </div>
<div>Module Release testing (STIF) : MRT subset </div>
<div> </div>
<div>Test case(s) Added : No.</div>
<div> </div>
<div>Memory leak check performed : Yes. No new leaks introduced </div>
<div> </div>
<div>Platforms and Profiles Build Verified: helix-client-s60-50-mmf-mdf-dsp</div>
<div> </div>
<div>helix-client-s60-52-mmf-mdf-dsp</div>
<div> </div>
<div>Platforms and Profiles Functionality verified: armv5, winscw </div>
<div> </div>
<div>Branch: cay210, brizo420, HEAD</div>
<div> </div>
<div> </div>
<div> </div>
<div> </div>
</font>
</body>
</html>
["diff.txt" (text/plain)]
? diff.txt
Index: aviffpln.cpp
===================================================================
RCS file: /cvsroot/datatype/avi/fileformat/aviffpln.cpp,v
retrieving revision 1.5.6.3
diff -u -w -r1.5.6.3 aviffpln.cpp
--- aviffpln.cpp 2 Dec 2009 18:37:10 -0000 1.5.6.3
+++ aviffpln.cpp 16 Dec 2009 20:26:49 -0000
@@ -610,12 +610,13 @@
CAVIStream* pStream = (CAVIStream*) m_streamArray[usStream];
HX_ASSERT_VALID_PTR(pStream);
-#ifndef HELIX_FEATURE_AVI2
- if(m_pIndex)
+#ifdef HELIX_FEATURE_AVI2
+ if(!m_bHasAviOdmlIndex)
+#endif
{
pStream->SetIndex(m_pIndex);
}
-#endif
+
if (SUCCEEDED(pStream->GetHeader(pHeader)))
{
@@ -2036,13 +2037,14 @@
if (pStream->PendingHeaderRequest())
{
-#ifndef HELIX_FEATURE_AVI2
- if (m_pIndex)
+#ifdef HELIX_FEATURE_AVI2
+ if (!m_bHasAviOdmlIndex)
+#endif
{
// AVIIndex is not needed if ODMLIndex is found.
pStream->SetIndex(m_pIndex);
}
-#endif
+
IHXValues* pHeader = NULL;
if (SUCCEEDED(m_pCommonClassFactory->CreateInstance(CLSID_IHXValues,
(void**)&pHeader)))
_______________________________________________
Datatype-dev mailing list
Datatype-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic