[prev in list] [next in list] [prev in thread] [next in thread]
List: helix-datatype-dev
Subject: [datatype-dev] CR:-Made change to CMdfVideoAdapter::InitL to return
From: <saleem.adookkattil () nokia ! com>
Date: 2009-11-25 20:10:56
Message-ID: 19113978AB61DA44AC317B211CF1C32A26B1F6D1C6 () NOK-EUMSG-02 ! mgdnok ! nokia ! com
[Download RAW message or body]
"Nokia submits this code under the terms of a commercial contribution agreement with \
Real Networks, and I am authorized to contribute this code under said agreement."
Modified by: saleem.adookkattil@nokia.com
Reviewed by:
Date: 11/25/2009
Project: phonon_backend
ErrorId: N/A
Synopsis: Made change to CMdfVideoAdapter::InitL to return error on failure to find \
IHXSymbianGraphcisSurfaceObserver interface pointer.
Overview: Returning success error code (HXR_OK) from CMdfVideoAdapter::InitL on \
failure to find IHXSymbianGraphcisSurfaceObserver interface cause crash when methods \
of this interface are called from CMdfVideoAdapter instance methods.
Files modified:
cvsroot\datatype\mdf\video\renderer\mdfvideoadapter.cpp
Files added: None
Image Size and Heap Use impact: None.
Module Release testing (STIF) : N/A
Test case(s) Added : No
Memory leak check performed : Yes
Platforms and Profiles Build Verified: helix-client-s60-52-ng
Platforms and Profiles Functionality verified: armv5, winscw
Branch: HEAD, 4_2_0_brizo
Index: mdfvideoadapter.cpp
===================================================================
RCS file: /cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp,v
retrieving revision 1.107.2.1
diff -u -w -r1.107.2.1 mdfvideoadapter.cpp
--- mdfvideoadapter.cpp 25 Sep 2009 14:03:25 -0000 1.107.2.1
+++ mdfvideoadapter.cpp 25 Nov 2009 18:24:10 -0000
@@ -639,7 +639,7 @@
retVal = CHXSymbianErrorMapper::MapToHXStatus(retFlag);
}
}
- m_pContext->QueryInterface(IID_IHXSymbianGraphcisSurfaceObserver, \
(void**)&m_pGraphcisSurfaceObs); + retVal \
=m_pContext->QueryInterface(IID_IHXSymbianGraphcisSurfaceObserver, \
(void**)&m_pGraphcisSurfaceObs); #endif //#if \
defined(HELIX_FEATURE_SYMBIAN_GRAPHICS_SURFACES) }
else
[Attachment #3 (text/html)]
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from rtf -->
<style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 \
2px solid; } --></style> </head>
<body>
<font face="Arial, sans-serif" size="2">
<div>"Nokia submits this code under the terms of a commercial contribution \
agreement with Real Networks, and I am authorized to contribute this code under said \
agreement."</div> <div> </div>
<div>Modified by: saleem.adookkattil@nokia.com</div>
<div> </div>
<div>Reviewed by:</div>
<div> </div>
<div>Date: 11/25/2009</div>
<div> </div>
<div>Project: phonon_backend</div>
<div> </div>
<div>ErrorId: N/A</div>
<div> </div>
<div>Synopsis: Made change to CMdfVideoAdapter::InitL to return error on failure to \
find IHXSymbianGraphcisSurfaceObserver interface pointer.</div> <div> </div>
<div>Overview: Returning success error code (HXR_OK) from CMdfVideoAdapter::InitL on \
failure to find IHXSymbianGraphcisSurfaceObserver interface cause crash when methods \
of this interface are called from CMdfVideoAdapter instance methods.</div> \
<div> </div> <div>Files modified:</div>
<div> </div>
<div>cvsroot\datatype\mdf\video\renderer\mdfvideoadapter.cpp \
</div> <div> </div>
<div>Files added: None</div>
<div> </div>
<div>Image Size and Heap Use impact: None.</div>
<div> </div>
<div>Module Release testing (STIF) : N/A</div>
<div> </div>
<div>Test case(s) Added : No</div>
<div> </div>
<div>Memory leak check performed : Yes</div>
<div> </div>
<div>Platforms and Profiles Build Verified: helix-client-s60-52-ng</div>
<div> </div>
<div>Platforms and Profiles Functionality verified: armv5, winscw</div>
<div> </div>
<div>Branch: HEAD, 4_2_0_brizo</div>
<div> </div>
<div>Index: mdfvideoadapter.cpp</div>
<div>===================================================================</div>
<div>RCS file: /cvsroot/datatype/mdf/video/renderer/mdfvideoadapter.cpp,v</div>
<div>retrieving revision 1.107.2.1</div>
<div>diff -u -w -r1.107.2.1 mdfvideoadapter.cpp</div>
<div>--- mdfvideoadapter.cpp 25 Sep 2009 14:03:25 -0000 \
1.107.2.1</div> <div>+++ mdfvideoadapter.cpp 25 Nov 2009 18:24:10 \
-0000</div> <div>@@ -639,7 +639,7 @@</div>
<div> \
retVal = CHXSymbianErrorMapper::MapToHXStatus(retFlag); \
</div> <div> \
}</div> <div> \
}</div> <div>- \
m_pContext->QueryInterface(IID_IHXSymbianGraphcisSurfaceObserver, \
(void**)&m_pGraphcisSurfaceObs);</div> \
<div>+ retVal \
=m_pContext->QueryInterface(IID_IHXSymbianGraphcisSurfaceObserver, \
(void**)&m_pGraphcisSurfaceObs);</div> <div> #endif //#if \
defined(HELIX_FEATURE_SYMBIAN_GRAPHICS_SURFACES)</div> \
<div> }</div> \
<div> else</div> <div> </div>
</font>
</body>
</html>
_______________________________________________
Datatype-dev mailing list
Datatype-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-dev
--===============0990364040==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic