[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-datatype-dev
Subject:    [datatype-dev] Re: CR/CN: Fix for Bug 9720 : Messaging application
From:       ugundeli () real ! com
Date:       2009-11-23 19:38:05
Message-ID: 1170.172.22.127.242.1259005085.squirrel () mailone ! real ! com
[Download RAW message or body]

Incorporated your suggested changes and checked in.
thanks,
-Umakant.
> If there are defines in ffdriver.h for "StartTime" and
> "UseFileRecognition", then we should use them.
>
> Rest looks good.
>
> Eric
>
> On Nov 22, 2009, at 7:24 PM, ugundeli@real.com wrote:
>
>> Project: Real Player for Android
>>
>> Synopsis: Fix for Bug 9720 : Messaging application can not capture
>> thumbnails of video.
>>
>> Overview: This CR fixes the bug 9720 : Messaging application can not
>> capture thumbnails of video. This bug is fixed by creating a proper
>> fd://
>> formatted filename in MetaDataDriver.cpp's setDataSource() method,
>> adding
>> "HELIX_FEATURE_DTDR_USE_RECOGNIZER" define to
>> helix-client-android-full.pf, setting "UseFileRecognition" flag for
>> DtDriver in thumbnail_service.cpp and finally fixing very minor problem
>> in
>> ffdriver.cpp.
>>
>> About the change in ffdriver.cpp: In case of State_FindFileFormats, if
>> "HELIX_FEATURE_DTDR_USE_RECOGNIZER" is defined, it assumes that MimeType
>> is already found out using recognizer. but there can be a situation
>> where
>> "HELIX_FEATURE_DTDR_USE_RECOGNIZER" is defined BUT the application using
>> DtDriver may NOT have set "UseFileRecognition" flag and thus state
>> State_RecognizeFormat NEVER gets triggered and MimeType is NULL.
>> Therefore, DtDriver may end up finding INCORRECT or NO fileformat at
>> all.
>>
>> Files Added: None
>>
>> Files Modified:
>> datatype/tools/dtdriver/engine/ffdriver.cpp
>> player/common/dtdr_service/thumbnail_service/thumbnailservice.cpp
>> player/kit/android/MetaDataDriver.cpp
>> cvsroot/ribosome/build/umakepf/helix-client-android-full.pf
>>
>> Platforms and Profiles Build and Functionality Verified:
>> Platform: android-donut-arm.eabi
>> Profile: helix-client-android
>> target(s): android_all
>>
>> Branch: hxclient_3_6_1_atlas_restricted
>>        hxclient_3_1_0_atlas
>>
>> Attachment:
>> bug9720_fix_diff.txt
>>
>> thanks,
>> -Umakant.<bug9720_fix_diff.txt>_______________________________________________
>> Porting-android mailing list
>> Porting-android@lists.helixcommunity.org
>> http://lists.helixcommunity.org/mailman/listinfo/porting-android
>
> Eric Hyche (ehyche@real.com)
> Principal Engineer
> RealNetworks, Inc.
>
>
>
>



_______________________________________________
Datatype-dev mailing list
Datatype-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-dev
[prev in list] [next in list] [prev in thread] [next in thread]