'[datatype-dev] CN: Added Decode Support For SPARK'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-datatype-dev
Subject:    [datatype-dev] CN: Added Decode Support For SPARK
From:       "manju" <mmanjunath () real ! com>
Date:       2009-11-19 5:42:41
Message-ID: 20091119055140.7746C830B3 () spamwall ! internal ! helixcommunity ! org
[Download RAW message or body]

This is also checked into 361_atlas, 347_atlas and 3_4_10_atlas.

-----Original Message-----
From: manju [mailto:mmanjunath@real.com] 
Sent: Friday, October 16, 2009 12:34 PM
To: 'Eric Hyche'
Cc: 'datatype-dev@helixcommunity.org'
Subject: RE: [datatype-dev] RESEND:CR: Added Decode Support For SPARK

Thanks Eric for looking into this.

1) What is the opaque data for Sorensen? It looks like you
    are passing the entire first frame. Does the entire first
    frame get passed to the decoder in PNCodec_StreamOpen()?
    Why? I don't think the H.263 decoder in normal H.263 mode even
    required having any opaque data.

Yes, I need this change, I am using opaque data filled first frame in
PNCodec_StreamOpen(). Where I parse picture layer to get the width and
height (spark also has 2 custom size types) of the frame to decide the
imagesize which will be used in PNStream_SetDataCallback()to set
outputaloocator buffersize (place holder for decoded buffer size decided).

All other suggested naming style changes has been done.

Note, mp4 video render and payload changes to support FLV contents are only
checked into head, this is not present in 310_atlas and 401_brizo, so I will
directly check in those required changes with mine to 310_atlas and
401_brizo.

Thanks,
-Manju

-----Original Message-----
From: Eric Hyche [mailto:ehyche@real.com] 
Sent: Thursday, October 15, 2009 7:02 PM
To: manju
Cc: datatype-dev@helixcommunity.org
Subject: Re: [datatype-dev] RESEND:CR: Added Decode Support For SPARK

Here are my comments:

1) What is the opaque data for Sorensen? It looks like you
    are passing the entire first frame. Does the entire first
    frame get passed to the decoder in PNCodec_StreamOpen()?
    Why? I don't think the H.263 decoder in normal H.263 mode even
    required having any opaque data.

2) m_opaquedata and m_opaquedataSize should be renamed to
    following coding style guidelines: m_pOpaqueData and
    m_ulOpaqueDataSize, respectively.

3) Instead of hard-coding a "2" for Spark, use the defines
    for Sorensen spark in datatype/flash/flv/common/pub/flvparse.h.

4) When you set the "OpaqueData" property in the FLV file format,
    you should use the CreateAndSetBufferCCF() method in
    common/util/pckunpck.cpp in order to reuse code.

5) New .cpp and .h file need proper Helix license headers. For .cpp and
    .h files, you should use 2.1.1 from here:
    http://asg-plone.dev.prognet.com/helix/moin.cgi/SourceFileHeaders

6) m_isSpark should follow the Helix coding style guidelines here:
    https://helix-server.helixcommunity.org/2003/devdocs/ 
codingstyle.html
    and be named m_bIsSpark.

Rest looks good.

Eric

On Oct 15, 2009, at 8:49 AM, manju wrote:

> RESENDING
>
> Project:
> Real Player for Android/Netbook
>
> Synopsis:
> Added support for decoding spark encoded FLV video contents.
>
> Overview:
> Added Support for spark FLV video content decoding for helix head.  
> We can render Spark Video Natively
> [License header for newly added files will be added while check in]
>
> Folders Added:
>  /cvsroot/datatype/h263/decoder_spark
>
> Files Added:
>  /cvsroot/datatype/ h263/decoder_spark/spark_codec.cpp
>  /cvsroot/datatype/ h263/decoder_spark/spark_codec.h
>  /cvsroot/datatype/ h263/decoder_spark/sparkcodecapi.cpp
>  /cvsroot/datatype/ h263/decoder_spark/Umakefil
>
> Files Removed:
> None
>
> Files Modified:
>  /cvsroot/datatype/mp4/payload/flvpyld.cpp
> /cvsroot/datatype/mp4/payload/pub/flvpyld.h
> /cvsroot/datatype/flash/flv/fileformat/flv_file_format.cpp
> /cvsroot/datatype/flash/flv/fileformat/pub/flv_file_format.h
>
> Files Attached:
> Mp4payloaddiff.txt
> Flvfileformatdiff.txt
> spark_codec.cpp
> spark_codec.h
> sparkcodecapi.cpp
> Umakefil
>
> Platforms and Profiles Build Verified:
> BIF branch   ->helix_restricted
> Target(s)      ->splay
> Profile          ->helix-client-all-defines
>
> Regards,
> Manju
>
> < 
> mp4payloaddiff.txt 
> > 
> < 
> flvfileformatdiff.txt 
> > 
> < 
> sparkcodecapi.cpp 
> > 
> < 
> Umakefil 
> > 
> < 
> spark_codec.cpp 
> ><spark_codec.h>_______________________________________________
> Datatype-dev mailing list
> Datatype-dev@helixcommunity.org
> http://lists.helixcommunity.org/mailman/listinfo/datatype-dev

Eric Hyche (ehyche@real.com)
Principal Engineer
RealNetworks, Inc.

_______________________________________________
Datatype-dev mailing list
Datatype-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-dev
[prev in list] [next in list] [prev in thread] [next in thread] 