[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-datatype-dev
Subject:    RE: [datatype-dev] CR:Fix for panic in video thumbnail generation
From:       "Eric Hyche" <ehyche () real ! com>
Date:       2009-03-26 15:11:40
Message-ID: 00b001c9ae25$2b896f60$829c4e20$ () com
[Download RAW message or body]

Looks good.

=======================================
Eric Hyche (ehyche@real.com)
Principal Engineer
RealNetworks, Inc.


>-----Original Message-----
>From: datatype-dev-bounces@helixcommunity.org [mailto:datatype-dev-bounces@helixcommunity.org] On
>Behalf Of Ashish.As.Gupta@nokia.com
>Sent: Thursday, March 26, 2009 10:57 AM
>To: datatype-dev@helixcommunity.org
>Subject: [datatype-dev] CR:Fix for panic in video thumbnail generation when graphics surfaces are
>enabled.
>
>Fix for panic in video thumbnail generation when graphics surfaces are enabled.
>
>Nokia submits this code under the terms of a commercial contribution agreement with RealNetworks, and
>I am authorized to contribute this code under said agreement."
>
>Modified by:  ashish.as.gupta@nokia.com
>
>Reviewed by:
>
>Date: 26-Mar-2009
>
>Project: symbianMmf_wm
>
>TSW-Id: JSEA-7Q2E5X
>
>Synopsis:
>
>MDF video server session is incorrectly using the PostProcHWDevice without checking whether the
>postprocessor is enabled. PostProcessor is disabled for tihe video thumbnail generation use case. In
>this case, when PostProcHWDevice is used it causes the panic.
>
>Fix is to use the PostProcesHWDevice only when the PostProcessor is enabled.
>
>Files Modified:
>datatype/mdf/video/renderer/mdfdevice/server/CMDFDevVideoServerSession.cpp
>
>Image Size and Heap Use impact: none
>
>Module Release testing (STIF): Yes, TNE use case was tested.
>
>Test case(s) Added: none
>
>Memory leak check performed: Yes.
>
>Platforms and Profiles Build Verified:
>    armv5  / helix-client-s60-52-mmf-mdf-dsp / 210Cays
>    winscw / helix-client-s60-52-mmf-mdf-dsp / 210Cays
>
>Platforms and Profiles Functionality Verified:
>    winscw / helix-client-s60-52-mmf-mdf-dsp / 210Cays
>
>Branch:
>    210Cays, HEAD
>
>
>Index: CMDFDevVideoServerSession.cpp
>===================================================================
>RCS file: /cvsroot/datatype/mdf/video/renderer/mdfdevice/server/CMDFDevVideoServerSession.cpp,v
>retrieving revision 1.1.2.14
>diff -u -w -r1.1.2.14 CMDFDevVideoServerSession.cpp
>--- CMDFDevVideoServerSession.cpp	2 Mar 2009 17:24:20 -0000	1.1.2.14
>+++ CMDFDevVideoServerSession.cpp	26 Mar 2009 04:36:17 -0000
>@@ -936,13 +936,14 @@
>     }
> #endif
> #if defined(HELIX_FEATURE_S60_VIDEO_CUSTOM_INTERFACE) && defined(S60_HX_GRAPHICS_SURFACE) &&
>defined(HELIX_FEATURE_SYMBIAN_GRAPHICS_SURFACES)
>+	if (!pInitParams->m_bDisablePostProcessor)
>+		{
>                 m_pVideoSurfaceSupport = (MMMFVideoSurfaceSupport *) m_pDevVideoPlay-
>>CustomInterface(m_PostProcessorHwDeviceId, KUidMMFVideoSurfaceSupport );
>                 if( m_pVideoSurfaceSupport )
>                 {
>                     m_pVideoSurfaceSupport->MmvssSetObserver(*this);
>-
>                 }
>-
>+	}
> #endif
>     User::LeaveIfError(lRetval);
>
>_______________________________________________
>Datatype-dev mailing list
>Datatype-dev@helixcommunity.org
>http://lists.helixcommunity.org/mailman/listinfo/datatype-dev


_______________________________________________
Datatype-dev mailing list
Datatype-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-dev
[prev in list] [next in list] [prev in thread] [next in thread]