[prev in list] [next in list] [prev in thread] [next in thread]
List: helix-datatype-dev
Subject: RE: [datatype-dev] CR: ENGV-7CNE2R - System error when playing
From: "Eric Hyche" <ehyche () real ! com>
Date: 2008-04-16 12:30:45
Message-ID: 003401c89fbd$b2588480$db68a8c0 () EHYCHED620
[Download RAW message or body]
Looks good.
=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.
> -----Original Message-----
> From: datatype-dev-bounces@helixcommunity.org
> [mailto:datatype-dev-bounces@helixcommunity.org] On Behalf Of
> ext-ashwinkumar.1.nadagoudar@nokia.com
> Sent: Tuesday, April 15, 2008 12:04 PM
> To: datatype-dev@helixcommunity.org
> Subject: [datatype-dev] CR: ENGV-7CNE2R - System error when
> playing videofile
>
>
> "Nokia submits this code under the terms of a
> commercial contribution agreement with RealNetworks, and I am
> authorized to contribute this code under said agreement."
>
> Modified by:
> ext-ashwinkumar.1.nadagoudar@nokia.com
>
> Reviewed by:
>
> Date: 04/15/08
>
> Project: SymbianMmf_Rel
>
> ErrorId: ENGV-7CNE2R
>
> Synopsis: System error when playing video file
>
> Overview: For the clip which has Audio
> compression AMR-WB and does not contain opaque
> data(m_pOpaqueData) with it, HX_RESULT
> CQT_TrackInfo_Manager::InitNonHinted(..) method returns fail
> which is causing the sytem error.
>
> Solution: Remove the else part which
> validates m_pOpaqueData and returns HXR_FAIL. This fix is
> already there in the Head.
>
> Files modified:
> \datatype\mp4\fileformat\qtatmmgs.cpp
>
> Files added:
> None.
>
>
> Image Size and Heap Use impact: minor.
>
> Module Release testing (STIF) : Yes, Passed
>
> Test case(s) Added : 1 test case will be added
>
> Memory leak check performed : Yes. No
> new memory leaks introduced.
>
> Platforms and Profiles Build Verified:
> helix-client-s60-50-mmf-mdf-arm
>
> Platforms and Profiles Functionality
> verified: armv5, winscw
>
> Branch: 210CayS
>
>
> Index: qtatmmgs.cpp
>
> ===================================================================
> RCS file:
> /cvsroot/datatype/mp4/fileformat/qtatmmgs.cpp,v
> retrieving revision 1.29.2.5
> diff -w -u -b -r1.29.2.5 qtatmmgs.cpp
> --- qtatmmgs.cpp 9 Jan 2008
> 15:20:05 -0000 1.29.2.5
> +++ qtatmmgs.cpp 14 Apr 2008
> 22:57:19 -0000
> @@ -2149,13 +2149,6 @@
> }
> #endif // HELIX_FEATURE_3GPPCLIENT_ONLY
> }
> - else
> - {
> - if (retVal == HXR_OK)
> - {
> - retVal = HXR_FAIL;
> - }
> - }
> }
> #ifdef QTCONFIG_TIMEDTEXT_PACKETIZER
> else if
> (pSampleDescManager->GetNumEntries() > 1 &&
>
>
_______________________________________________
Datatype-dev mailing list
Datatype-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-dev
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic