[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-datatype-dev
Subject:    RE: [Clientapps-dev] FW: [datatype-dev] CR: RESEND thumbnail
From:       "Eric Hyche" <ehyche () real ! com>
Date:       2008-01-24 6:16:56
Message-ID: 001001c85e50$b8c8c860$e58e17ac () EHYCHED620
[Download RAW message or body]


Ashish,

Here are my comments:

+if not project.IsDefined('HELIX_CONFIG_DTDR_THUMBNAIL'):

+#ifdef HELIX_FEATURE_DTDR_THUMBNAIL

Is there both a HELIX_CONFIG_DTDR_THUMBNAIL and
a HELIX_FEATURE_DTDR_THUMBNAIL? Seems like it should
either be a feature or a config, but not both. I would
think this is a feature.

The rest looks good.

Eric

=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: clientapps-dev-bounces@helixcommunity.org 
> [mailto:clientapps-dev-bounces@helixcommunity.org] On Behalf 
> Of Ashish.As.Gupta@nokia.com
> Sent: Wednesday, January 23, 2008 11:22 AM
> To: datatype-dev@helixcommunity.org; clientapps-dev@helixcommunity.org
> Subject: [Clientapps-dev] FW: [datatype-dev] CR: RESEND 
> thumbnail supportusing dtdriver
> 
>  
> 
> ________________________________
> 
> From: datatype-dev-bounces@helixcommunity.org 
> [mailto:datatype-dev-bounces@helixcommunity.org] 
> Sent: Tuesday, January 22, 2008 1:33 PM
> To: datatype-dev@helixcommunity.org; clientapps-dev@helixcommunity.org
> Subject: [datatype-dev] CR: thumbnail support using dtdriver
> 
> 
> 
> Nokia submits this code under the terms of a commercial 
> contribution agreement with RealNetworks, and I am authorized 
> to contribute this code under said agreement."
> 
> Modified by:  ashish.as.gupta@nokia.com 
> 
> Reviewed by: 
> 
> Date: 20-Jan-2008 
> 
> Project: SymbianMmf_wm 
> 
> TSW: Req-Id:410-199 
> 
> Synopsis: 
> 
> This CR adds support for thumbnail generation. 
> 
> 1. DTDriver: 
> There are minor changes and bug fixes done to dtdriver. 
> 
> 2. CHXSymbianMetadataEng. 
> A new feature flag HELIX_FEATURE_DTDR_THUMBNAIL is added. 
> CHXTNEngine is derived from CHXSymbianMetaDataEng. It 
> receives the decoded YUV frames from the DTDriver 
> and passes them to utility class using a new observer 
> interface, MHXTNEEngineObserver. 
> 
> CHXTNEngine uses following params for the configuration of DTDriver. 
> 
>     QUIET_OPTION_NAME, 
>     FILERECOGNITION_OPTION_NAME, 
>     DECODEVIDEO_OPTION_NAME, 
>     DECODE_OPTION_NAME, 
>     JUMPSTART_OPTION_NAME. 
> 
> CHXTNEEngine uses its own dll_names file for plugin dlls. 
> Variation between Metadata engine and thumbnail engine is 
> achived by a new interface MHXEngineProperties that allows 
> selection of seperate configuration files and properties.
> 
> 3. Symbian MMF Controller 
> installMmf.pcf is modified so that metadataengine and 
> thumbnail engine support is avaialble through sis files. 
> 
> 4. Build System Changes 
> HELIX_FEATURE_DTDR_THUMBNAIL is added  and 
> helix-s60-metadataengine.pfi is modified to use DTDrivers 
> decoding feature. 
> 
> 
> 
> Files Modified: 
>     datatype/mdf/video/renderer/mdfvideoadapter.cpp 
>     datatype/tools/dtdriver/common/reporterror.cpp 
>     datatype/tools/dtdriver/decoder/audio/adecoder.cpp 
>     datatype/tools/dtdriver/decoder/video/vdecoder.cpp 
>     datatype/tools/dtdriver/engine/csrchdlrstackfact.cpp 
>     datatype/tools/dtdriver/engine/ffdriver.cpp 
>     datatype/tools/metadataeng/engine/Umakefil 
>     datatype/tools/metadataeng/engine/hxdll.cpp 
>     datatype/tools/metadataeng/engine/metadataeng.cpp 
>     datatype/tools/metadataeng/engine/metadataeng.h 
>     datatype/tools/metadataeng/engine/metadataengbase.cpp 
>     datatype/tools/metadataeng/engine/symbian.pcf 
>     
> datatype/tools/metadataeng/engine/platform/symbian/symbian_met
> adataeng.cpp 
>     datatype/tools/metadataeng/engine/pub/hxmetadatalog.h 
>     datatype/tools/metadataeng/engine/pub/metadataengbase.h 
>     
> datatype/tools/metadataeng/engine/pub/platform/symbian/symbian
> _metadataeng.h 
>     datatype/tools/metadataeng/utility/symbian.pcf 
>     
> datatype/tools/metadataeng/utility/platform/symbian/hxmetadata
> util.cpp 
>     
> datatype/tools/metadataeng/utility/platform/symbian/hxmetadatautil.h 
> 
>     clientapps/symbianMmf/videocontroller/installMMF.pcf 
>     build/umakepf/helix-s60-metadataengine.pfi 
> 
> Files Added: 
>     datatype/tools/metadataeng/engine/ 
>     datatype/tools/metadataeng/engine/pub/hxtne_obs.h 
>     datatype/tools/metadataeng/engine/platform/symbian/hxtedefines.h 
>     
> datatype/tools/metadataeng/engine/pub/platform/symbian/symbian
> _thumbnaileng.h 
>     
> datatype/tools/metadataeng/engine/platform/symbian/symbian_thu
> mbnaileng.cpp 
>     datatype/tools/metadataeng/utility/platform/symbian/hxtnutil.cpp 
>     
> datatype/tools/metadataeng/utility/platform/symbian/hxtnutil_impl.cpp 
>     datatype/tools/metadataeng/utility/platform/symbian/hxtnutil.h 
>     
> datatype/tools/metadataeng/utility/platform/symbian/hxtnutil_impl.h 
>     
> datatype/tools/metadataeng/utility/platform/symbian/hxtnutil_obs.h 
> 
> Image Size and Heap Use impact: 
>     minor 
> 
> Module Release testing (STIF): Yes. 
> 
> Test case(s) Added: none 
> 
> Memory leak check performed: Yes, no new leaks introduced. 
> 
> Platforms and Profiles Build Verified: 
>     armv5 / helix-client-s60-32-mmf-mdf-arm 
>     winscw / helix-client-s60-32-mmf-mdf-arm 
> 
> Platforms and Profiles Functionality verified: 
>     armv5 / helix-client-s60-32-mmf-mdf-arm 
> <<build_diff.txt>> 
> <<clientapps_symbianMmf_videocontroller_diff.txt>> 
> <<datatype_tools_diff.txt>> <<new_files.tar.gz>> 
> 
> 


_______________________________________________
Datatype-dev mailing list
Datatype-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-dev
[prev in list] [next in list] [prev in thread] [next in thread]