[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-datatype-dev
Subject:    [datatype-dev] CN-Client: fix in dtdrive packet engine
From:       "Eric Hyche" <ehyche () real ! com>
Date:       2007-04-23 17:57:37
Message-ID: 00d301c785d0$e1cb7e50$db68a8c0 () EHYCHED620
[Download RAW message or body]


This is now checked into HEAD and 150cay.

=============================================
Eric Hyche (ehyche@real.com)
Technical Lead
RealNetworks, Inc.  

> -----Original Message-----
> From: Greg Wright [mailto:gwright@real.com] 
> Sent: Monday, April 23, 2007 1:44 PM
> To: ehyche@real.com
> Cc: datatype-dev@lists.helixcommunity.org
> Subject: Re: [datatype-dev] CR-Client: fix in dtdrive packet engine
> 
> Looks good.
> --greg.
> 
> 
> Eric Hyche wrote:
> > Description
> > ---------------------------------------
> > During transcoding, the dtdrive packet engine
> > could still wind up calling GetPacket(streamNum) on
> > a fileformat plugin even though the fileformat
> > had already called StreamDone(streamNum). Some 
> > fileformats simply ignore these calls, while
> > this causes an assert in others.
> > 
> > This change puts a guard in place so that GetPacket()
> > is not called on a stream that has already returned
> > StreamDone().
> > 
> > Files Modified
> > ------------------------------------
> > datatype/tools/dtdriver/engine/ffdriver.cpp
> > 
> > Branches
> > ------------------------------------
> > HEAD and 150cay
> > 
> > Index: ffdriver.cpp
> > ===================================================================
> > RCS file: /cvsroot/datatype/tools/dtdriver/engine/ffdriver.cpp,v
> > retrieving revision 1.37
> > diff -u -w -u -w -r1.37 ffdriver.cpp
> > --- ffdriver.cpp        25 Jan 2007 19:46:55 -0000      1.37
> > +++ ffdriver.cpp        23 Apr 2007 17:37:43 -0000
> > @@ -4840,7 +4840,10 @@
> >          m_pFFDriver->m_ulGetPacketEvents++;
> > 
> >         m_pFFDriver->m_bPacketReady = FALSE;
> > +        if (!m_pFFDriver->m_bStreamDoneArray[m_uStream])
> > +        {
> >         m_pFileFormat->GetPacket(m_uStream);
> > +        }
> >         if (!m_pFFDriver->m_bPacketReady)
> >         {
> >             m_pFFDriver->SelectNextStream();
> > 
> > 
> > 
> > =============================================
> > Eric Hyche (ehyche@real.com)
> > Technical Lead
> > RealNetworks, Inc. 
> > 
> > 
> > _______________________________________________
> > Datatype-dev mailing list
> > Datatype-dev@helixcommunity.org
> > http://lists.helixcommunity.org/mailman/listinfo/datatype-dev
> 


_______________________________________________
Datatype-dev mailing list
Datatype-dev@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-dev
[prev in list] [next in list] [prev in thread] [next in thread]