[prev in list] [next in list] [prev in thread] [next in thread]
List: helix-datatype-cvs
Subject: [Datatype-cvs] aac/fileformat/pub aacff.h, 1.14.16.4.2.3, 1.14.16.4.2.4
From: fashengli () helixcommunity ! org
Date: 2012-07-20 5:44:16
[Download RAW message or body]
Update of /cvsroot/datatype/aac/fileformat/pub
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv7015/pub
Modified Files:
Tag: hxclient_3_6_1_atlas
aacff.h
Log Message:
答复: [datatype-dev] CR: change to fix bug 14196: Metadata][AAC] The title, artist \
and album cannot be displayed Qing Li
Sent: Friday, July 20, 2012 10:34 AM
To: Fasheng Li; DL-china-helix-client-custproj-dev; Xiaolu Zhao; Henry Xing
Dear Fasheng,
the logic looks good, but please remove the following parts:
@@ -1,5 +1,5 @@
/* ***** BEGIN LICENSE BLOCK *****
- * Source last modified: $Id: smplfsys.cpp,v 1.46.2.2.8.8.4.1 2012/03/09 07:25:42 \
shuohuang Exp $ + * Source last modified: $Id: smplfsys.cpp,v 1.46.2.2.8.8.4.1 \
2012-03-09 07:25:42 shuohuang Exp $
*
* Portions Copyright (c) 1995-2004 RealNetworks, Inc. All Rights Reserved.
*
@@ -1,5 +1,5 @@
/* ***** BEGIN LICENSE BLOCK *****
- * Source last modified: $Id: smplfsys.h,v 1.17.2.1.38.2 2012/01/10 14:57:23 \
ching_li Exp $ + * Source last modified: $Id: smplfsys.h,v 1.17.2.1.38.2 2012-01-10 \
14:57:23 ching_li Exp $
*
* Portions Copyright (c) 1995-2004 RealNetworks, Inc. All Rights Reserved.
*
@@ -1,5 +1,5 @@
/* ***** BEGIN LICENSE BLOCK *****
- * Source last modified: $Id: hxfiles.h,v 1.16.2.1.16.3 2011/07/11 09:24:26 \
henryxing Exp $ + * Source last modified: $Id: hxfiles.h,v 1.16.2.1.16.3 2011-07-11 \
09:24:26 henryxing Exp $
*
* Portions Copyright (c) 1995-2004 RealNetworks, Inc. All Rights Reserved.
*
Best Regards!
Li Qing
--
RealNetworks China, Beijing Office
Tel: 008601059542848
Fax: 008601085656477
Address: 18th Floor,Tower B,Pacific Century Place,2A GongTiBeiLu,Chaoyang \
District,Beijing, China Post Code: 100027
________________________________________
发件人: Fasheng Li
发送时间: 2012年7月19日 18:54
收件人: Qing Li; DL-china-helix-client-custproj-dev; Xiaolu Zhao; Henry Xing
主题: RE: [datatype-dev] CR: change to fix bug 14196: Metadata][AAC] The title, \
artist and album cannot be displayed
Hi Qing,
I have modified the aacff.cpp according to your comments.
Regarding HELIX_FEATURE_64_BIT_FILE_SUPPORT, as we discussed, I have defined a new \
interface IHXFileObjectSync which can handle seek and read synchronously, and \
IHXFileObject2 inherits from this new interface.
Please help to review it again.
Thanks,
Fasheng
________________________________________
From: Qing Li
Sent: Wednesday, July 11, 2012 6:19 PM
To: Qing Li; Fasheng Li; DL-china-helix-client-custproj-dev; Xiaolu Zhao; Henry Xing
Subject: 答复: [datatype-dev] CR: change to fix bug 14196: Metadata][AAC] The \
title, artist and album cannot be displayed
one more suggestion:
it looks the following source codes can be wrapped as a function:
+ HX_RELEASE(XXXX);
+ retVal = m_pCommonClassFactory->CreateInstance(CLSID_IHXBuffer, (void \
**)&XXXX); + if (SUCCEEDED(retVal))
+ {
+ retVal = XXXX->Set(&pData[0], uItemLength+1);
+ if (SUCCEEDED(retVal))
+ {
+ (XXXX->GetBuffer())[ XXXX->GetSize() - 1] = '\0';
+ }
+ else
+ {
+ HX_RELEASE(XXXX);
+ break;
+ }
+ }
Best Regards!
Li Qing
--
RealNetworks China, Beijing Office
Tel: 008601059542848
Fax: 008601085656477
Address: 18th Floor,Tower B,Pacific Century Place,2A GongTiBeiLu,Chaoyang \
District,Beijing, China Post Code: 100027
________________________________________
发件人: Qing Li
发送时间: 2012年7月11日 18:14
收件人: Fasheng Li; DL-china-helix-client-custproj-dev; Xiaolu Zhao; Henry Xing
主题: 答复: [datatype-dev] CR: change to fix bug 14196: Metadata][AAC] The title, \
artist and album cannot be displayed
Dear Fasheng,
you should check if the macro HELIX_FEATURE_64_BIT_FILE_SUPPORT is defined before use \
IHXFileObject2 interface, if not you should use IHXFileObject interface to access the \
file. The logics looks good.
Best Regards!
Li Qing
--
RealNetworks China, Beijing Office
Tel: 008601059542848
Fax: 008601085656477
Address: 18th Floor,Tower B,Pacific Century Place,2A GongTiBeiLu,Chaoyang \
District,Beijing, China Post Code: 100027
________________________________________
发件人: Fasheng Li
发送时间: 2012年7月11日 17:31
收件人: DL-china-helix-client-custproj-dev; Xiaolu Zhao; Henry Xing
主题: FW: [datatype-dev] CR: change to fix bug 14196: Metadata][AAC] The title, \
artist and album cannot be displayed
Hi Experts,
Could you please help to review this CR for a internal bug?
Thanks,
Fasheng
-----Original Message-----
From: datatype-dev-bounces@helixcommunity.org \
[mailto:datatype-dev-bounces@helixcommunity.org] On Behalf Of Fasheng \
Li
Sent: 2012年5月25日 15:38
To: datatype-dev@helixcommunity.org
Subject: [datatype-dev] CR: change to fix bug 14196: Metadata][AAC] The title, artist \
and album cannot be displayed
Modified by: fashengli@realnetworks.com<mailto:fashengli@realnetworks.com>
Date: 05/25/2012
Project: RealPlayer for Android Smartphones
BugID: 14196
BugURL: https://bugs.helixcommunity.org/show_bug.cgi?id=14196
Synopsis: Change to fix bug 14196: Metadata][AAC] The title, artist and album \
cannot be displayed
Overview: Similar with MP3 file, AAC file may use ID3 or APEv2 tag to contain \
metadata information.
Some aac files don't have ID3 tag in the head of file but have APEv2 \
tag in the end of file.
When Media framework requests to extract metadata, helix will try to \
read tag in head. If no tag information; it will set metadata to \
NULL.
What we do is try to read tag in the end of file if no tag found in \
head.
This new feature has been modularized so it could be applied to other \
file formats easily.
Files Added: None
Files Modified:
datatype/aac/fileformat/aacff.cpp
datatype/aac/fileformat/pub/aacff.h
Image size and Heap Use impact(Client - Only): None
Platforms and Profiles Affected:
-- Platform: android-4.0-arm-qsd_8x60
-- Profile: helix-client-android-full
Distribution Libraries Affected: None
Distribution library impact and planned action: None
Platforms and Profiles Build Verified:
-- Platform: android-4.0-arm-qsd_8x60
-- Profile: helix-client-android-full
Platforms and Profiles Functionality Verified:
-- Platform: android-4.0-arm-qsd_8x60
-- Profile: helix-client-android-full
Branch: 361krill
Copyright assignment: I am a RealNetworks employee or contractor.
Best Regards,
Fasheng Li
Index: aacff.h
===================================================================
RCS file: /cvsroot/datatype/aac/fileformat/pub/aacff.h,v
retrieving revision 1.14.16.4.2.3
retrieving revision 1.14.16.4.2.4
diff -u -d -r1.14.16.4.2.3 -r1.14.16.4.2.4
--- aacff.h 3 May 2012 03:17:02 -0000 1.14.16.4.2.3
+++ aacff.h 20 Jul 2012 05:41:57 -0000 1.14.16.4.2.4
@@ -179,6 +179,8 @@
IHXBuffer* m_pAuthor;
IHXBuffer* m_pAlbum;
IHXBuffer* m_pTitle;
+ IHXBuffer* m_pComment;
+ IHXBuffer* m_pGenre;
IUnknown* m_pContext;
IHXFileObject* m_pFileObject;
IHXFormatResponse* m_pFormatResponse;
@@ -215,9 +217,13 @@
HX_RESULT FindFileType(UCHAR* pFrameBuffer, UINT8 uMask = FTYPE_ALL_MASK);
UINT32 GetMetaDataSize(UCHAR* pData);
UINT32 GetID3FrameSize(const UCHAR *pBuffer);
+ HX_RESULT CheckFooterMetaData();
+ UINT32 GetFooterMetaDataSize(UCHAR *pData);
+ HX_RESULT ProcessFooterMetaData(IHXBuffer* pBuffer);
// Callback function
static void CallbackStaticFunc(void* pParam);
void CallbackFunc();
+ HX_RESULT SetBuffer(IHXBuffer* &pBuffer, UCHAR *pData, UINT32 uItemLength);
};
#endif // #ifndef AACFF_H
_______________________________________________
Datatype-cvs mailing list
Datatype-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-cvs
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic