[prev in list] [next in list] [prev in thread] [next in thread] 

List:       helix-datatype-cvs
Subject:    [Datatype-cvs] wm/audio/renderer wmaformat.cpp,1.9.10.4,1.9.10.5
From:       krishnareddyr () helixcommunity ! org
Date:       2010-12-31 7:02:51
Message-ID: 201012310702.oBV72xD5005853 () mailer ! progressive-comp ! com
[Download RAW message or body]

Update of /cvsroot/datatype/wm/audio/renderer
In directory cvs01.internal.helixcommunity.org:/tmp/cvs-serv19249

Modified Files:
      Tag: hxclient_4_2_0_brizo
	wmaformat.cpp 
Log Message:
"Nokia submits this code under the terms of a commercial contribution agreement with \
Real Networks, and I am authorized to contribute this code under said agreement."  \
Modified by: ext-radhakrishna.reddy@nokia.com

 Reviewed by:  praveen.timmashetty@nokia.com , qluo@real.com

 RC Id: ou1cimx1#609913

 Date: 12/22/2010

 Project: symbain_client_apps

 Synopsis: Unable to resume playback after seeking wma clips

Overview: The packets are getting concealed because of the non progressive sequence \
number of audio only.wmv clip. Because of the non progressive sequence number the \
value of the bSeqNumSkip will be set to TRUE.  And this leads to enable the \
MDPCKT_FOLLOWS_LOSS_FLAG flag and continues the concealment. Since the concealment is \
called for the first packet after seek position and inturn not reaching the decoder. \
Because of this the value  of ulTimeLostInSamples  becomes very high value and \
concealment is called number of times until ulTimeLostInSamples becomes lesser than \
MAX_TOLERABLE_TIME_GAP which results as stuck for long time.

Fix: Adding the check in wmaformat.cpp under CWMAudioFormat::DecodeAudioData like  && \
(!pDecoder->IsDecoderRenderer()). so that when the HW decoder is available, the A/V \
sync is handled in H/Wdecoder renderer itself rather than going for concealment.  \
After adding this condition seeking working fine for local(having different sequence \
number files also) and streaming case also.

Files modified & changes:

\datatype\wm\audio\renderer\wmaformat.cpp

Image Size and Heap Use impact: No major impact

Module Release testing (STIF) : Partially done

Large number of STIFF test cases are failing on recent MCL baseline all H263 and \
MPEG4.Because its not getting the audio codec for Fourcc "amrn" and "amrw" i.e for \
the call CMMFCodec::NewL() we are getting NULL.So this thing is being analyzed \
separately.

Test case(s) Added : No

Memory leak check performed : Not applicable

Platforms and profiles build verified: helix-client-symbian-4

Platforms and Profiles Functionality verified: armv5, winscw

Branch: 420Brizo, HEAD

Diffs files: Attached.


Index: wmaformat.cpp
===================================================================
RCS file: /cvsroot/datatype/wm/audio/renderer/wmaformat.cpp,v
retrieving revision 1.9.10.4
retrieving revision 1.9.10.5
diff -u -d -r1.9.10.4 -r1.9.10.5
--- wmaformat.cpp	30 Dec 2010 09:38:21 -0000	1.9.10.4
+++ wmaformat.cpp	31 Dec 2010 07:02:48 -0000	1.9.10.5
@@ -561,7 +561,7 @@
                 }
                 // See if there was loss we need to conceal and added if condition \
when HW decoder is available   //conceal is not called for local files.
-                if ( (pAssembledFrame->m_ulFlags & MDPCKT_FOLLOWS_LOSS_FLAG) && \
(!pDecoder->IsDecoderRenderer())) +                if ( (pAssembledFrame->m_ulFlags & \
MDPCKT_FOLLOWS_LOSS_FLAG) && (!pDecoder->IsDecoderRenderer()))   {
                     // Is there a gap between the end of the last encoded frame
                     // and the beginning of this one?


_______________________________________________
Datatype-cvs mailing list
Datatype-cvs@helixcommunity.org
http://lists.helixcommunity.org/mailman/listinfo/datatype-cvs


[prev in list] [next in list] [prev in thread] [next in thread]